New issue
Advanced search Search tips

Issue 784363 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Check touch radius

Project Member Reported by beccahughes@chromium.org, Nov 13 2017

Issue description

The timeline is difficult to touch so we should check the touch radius.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd13db62bb05b98e99aaf7224c5524469549c4d4

commit bd13db62bb05b98e99aaf7224c5524469549c4d4
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Dec 12 11:18:11 2017

Media Controls: Increase touch radius on timeline

The timeline currently is 2px high. This converts the surrounding
margins into padding so the surrounding area will pick up touch events
and make it easier to scrub.

BUG= 784363 

Change-Id: I9ff370d5e0724a8e833aebc1fb2cde309dedd316
Reviewed-on: https://chromium-review.googlesource.com/819631
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523401}
[modify] https://crrev.com/bd13db62bb05b98e99aaf7224c5524469549c4d4/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e2d2727b669e1d75a0d32c6924feb13e14ff7c8

commit 6e2d2727b669e1d75a0d32c6924feb13e14ff7c8
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Dec 13 14:00:00 2017

Media Controls: Increase touch radius on audio element too

The audio element has more space so we can maximize the touch radius for
the timeline.

BUG= 784363 

Change-Id: Ief8f127e6cf1dc9cb08869891dc46f575d6c6d79
Reviewed-on: https://chromium-review.googlesource.com/824164
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523765}
[modify] https://crrev.com/6e2d2727b669e1d75a0d32c6924feb13e14ff7c8/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css

Sign in to add a comment