New issue
Advanced search Search tips

Issue 784362 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature


Participants' hotlists:
Modern-Media-Controls


Sign in to add a comment

Media Controls: Display message when scrubbing

Project Member Reported by beccahughes@chromium.org, Nov 13 2017

Issue description

When we are scrubbing display a message to prompt the user to jump
 
Screen Shot 2017-11-13 at 1.33.21 PM.png
146 KB View Download
Cc: steimel@chromium.org
Owner: ----
Status: Available (was: Assigned)
Owner: steimel@chromium.org
Status: Started (was: Available)
Here is a video showing the result of the initial patchset of crrev.com/c/870749
scrubbing_message.mp4
2.0 MB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a5d2c79878a0f445645afe313aa2ab092562a63

commit 4a5d2c79878a0f445645afe313aa2ab092562a63
Author: Tommy Steimel <steimel@chromium.org>
Date: Tue Feb 13 17:00:21 2018

Add scrubbing message to new media controls

This CL adds a message to the top of the media controls that lets the
user know they can double-tap the video to skip 10 seconds whenever the
user uses the scrubber on Android. It also adds a white gradient to the
top of the controls (mimicing the existing bottom one) so that the user
is able to see the message.

Bug:  784362 
Change-Id: Iceeda4b29ef7e1573d957fd05cfc0ceff58a8e06
Reviewed-on: https://chromium-review.googlesource.com/870749
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536391}
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/content/app/strings/content_strings.grd
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/content/child/blink_platform_impl.cc
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/LayoutTests/media/controls/modern/scrubbing.html
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/LayoutTests/media/media-controls.js
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/accessibility/AXMediaControls.cpp
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/BUILD.gn
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.cpp
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/MediaControlsImpl.h
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.cpp
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/MediaControlsResourceLoader.h
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementType.h
[add] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/elements/MediaControlScrubbingMessageElement.cpp
[add] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/elements/MediaControlScrubbingMessageElement.h
[add] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/resources/ic_arrow_left.svg
[add] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/resources/ic_arrow_right.svg
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/resources/media_controls_resources.grd
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls.css
[add] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/Source/modules/media_controls/resources/modernMediaControls_scrubbing_message.css
[modify] https://crrev.com/4a5d2c79878a0f445645afe313aa2ab092562a63/third_party/WebKit/public/platform/WebLocalizedString.h

Labels: -Type-Bug Type-Feature
Status: Fixed (was: Started)

Sign in to add a comment