New issue
Advanced search Search tips

Issue 784334 link

Starred by 1 user
Status: Fixed
Owner:
cfroussios@chromium.org
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 341477
issue 789561



Sign in to add a comment

Update Export passwords entry points

Project Member Reported by cfroussios@chromium.org, Nov 13 2017 
As per the mocks, the import/export button should be moved into a menu with a dots icons. The actions themselves should open dialogs, instead of jumping straight to file selection.

The two functionalities (import/export) will be made available separately by flags.

Comment 1 by cfroussios@chromium.org, Nov 13 2017

Blocking: 341477

Comment 3 by vabr@chromium.org, Nov 13 2017 

Also: go/kratj for the relevant UI review thread

Comment 4 by cfroussios@chromium.org, Nov 13 2017

Description: Show this description

Comment 5 by cfroussios@chromium.org, Nov 13 2017 

Attaching before and after screenshots for moving the buttons into a menu
before.png
62.6 KB View Download
after1.png
66.4 KB View Download
after2.png
68.2 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2a5b471a29fdd1f1beafb8d580539f18365364d

commit a2a5b471a29fdd1f1beafb8d580539f18365364d
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Nov 14 10:16:15 2017

🔐 Move import/export passwords buttons into a popup menu.

DD and mocks are in the bug.

Bug:  784334 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I1fd6778552902c67d94d063acab0b564b6b8f92d
Reviewed-on: https://chromium-review.googlesource.com/766188
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516249}
[modify] https://crrev.com/a2a5b471a29fdd1f1beafb8d580539f18365364d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/a2a5b471a29fdd1f1beafb8d580539f18365364d/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 21 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92cf740a719c53a1956612ed43f24089aabbcb07

commit 92cf740a719c53a1956612ed43f24089aabbcb07
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Nov 21 11:56:22 2017

🔐 Create popup dialog for exporting passwords

Introduced a dialog, as per
https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g284db53a0f_0_50

Progress bar and error message will be introduced later.

Bug:  784334 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I88aab41591a1e3d272b2b9b9dfc24e50486f02bd
Reviewed-on: https://chromium-review.googlesource.com/768714
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518220}
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/app/settings_strings.grdp
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/icons.html
[add] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.html
[add] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/passwords_and_forms_page/passwords_export_dialog.js
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/resources/settings/settings_resources.grd
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/92cf740a719c53a1956612ed43f24089aabbcb07/chrome/test/data/webui/settings/settings_passwords_section_browsertest.js

Comment 8 by cfroussios@chromium.org, Nov 29 2017

Status: Fixed (was: Assigned)
Summary: Update Export passwords entry points (was: Update Import/Export passwords entry points)
Rescoping this bug to export-only.

Comment 9 by cfroussios@chromium.org, Nov 29 2017

Blocking: 789561

Comment 10 by vabr@chromium.org, Nov 29

Cc: -vabr@chromium.org
►

Sign in to add a comment