New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784328 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Pixelbook keyboard Play/Pause key should toggle media playback in all tabs

Project Member Reported by fbeaufort@chromium.org, Nov 13 2017

Issue description

Chrome Version       : 64.0.3264.0
OS Version: 10116.0.0

What steps will reproduce the problem?
1. Open Google Play Music or Spotify to play some video/audio
2. Open other tabs while still listening to audio
3. Press Play/Pause key on keyboard

What is the expected result?
It should pause audio.

What happens instead of that?
It doesn't do anything. I have to go back to the tab playing audio before pressing that key to make it work which kinda defeats the purpose of this shortcut key...
 

Comment 1 by warx@chromium.org, Nov 13 2017

Cc: zalcorn@chromium.org
I believe current behavior is correct. +Zach for confirmation.
Components: -Internals>Media Internals>Media>Session

Comment 3 by warx@chromium.org, Nov 15 2017

Cc: -zalcorn@chromium.org warx@chromium.org
Owner: zalcorn@chromium.org
assigned to zalcorn@ for behavior conformation. Please assign back if it needs the change.
Status: WontFix (was: Unconfirmed)
We aren't able to do this reliably without MediaSession for Chrome Desktop. I believe this is being looked into for 2018.
zalcom@, what do you mean exactly? It would be possible to pause running playback. The issue I guess would be that resuming would require to resume all the playbacks that were previously played. I agree that waiting for audio focus on desktop would be easier. Though, is what I mention above the actual reason?

Comment 6 by derat@chromium.org, Mar 3 2018

Cc: derat@chromium.org
If we plan to do this at some point, mind keeping this open and marking it as blocked on the bug that tracks adding the functionality that's needed?

I think that there's a bigger question about whether it makes sense to pause everything the first time the key is pressed and not do anything when it's pressed again, though. If this key starts affecting unfocused tabs, there are lots of weird corner cases. I'm having a hard time thinking of ways to prevent this from being confusing to users.

Comment 7 by warx@chromium.org, Mar 3 2018

Code entry is here: https://cs.chromium.org/chromium/src/chrome/browser/ui/ash/media_client.cc?type=cs&q=handlemediaplayp&sq=package:chromium&l=168

It is possible to pause all unfocused browsers/tabs. If this is what we want, we then need to guarantee correct resuming I think, as in #5.

Re #6, if not doing anything when it's pressed again, it doesn't sound like play/pause key but just pause key.

Sign in to add a comment