Create a Shared State for Android Go stories |
||||||||||||||||
Issue descriptionThe shared state should allow to launch Chrome from various other entry points (e.g. CCT app, PWA home screen shortcuts).
,
Nov 17 2017
,
Nov 17 2017
,
Nov 21 2017
,
Nov 21 2017
,
Nov 22 2017
,
Nov 24 2017
Also blocked by: https://github.com/catapult-project/catapult/issues/1977
,
Dec 5 2017
,
Dec 15 2017
Issue 795229 has been merged into this issue.
,
Dec 15 2017
From Ned's comment #6 in the duped from bug:
> android_platform.LaunchApp('twitter')
> android_platform.Tap('id=....') # -> this triggers CCT
> android_platform.WaitFor('id=...') # Wait for CCT to appear on the screen
> alive_browsers = android_platform.GetAllRunningBrowserInstances()
> assert len(alive_browsers) == 1
> cct_browser = alive_browser[0]
> ... Do the rest of the user interaction with cct_browser ...
Note my current thinking is that rather than "GetAllRunningBrowserInstances", which could accidentally pick up some random browser we don't want, one would have a possible_browser instance (e.g. specifically for 'org.chromium.chrome') and do:
browser = possible_browser.FindBrowserInstance()
to create the (Python) browser object from an already running browser instance on the device; rather than the current:
browser = possible_browser.Create() [1]
which both starts the instance and creates the corresponding browser object.
[1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py?rcl=846f7660e7d5004afac6052a9d7905695bc1edb7&l=196
,
Jan 3 2018
,
Jan 11 2018
,
Jan 12 2018
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/e7298f36f7912f2caa122086cfbe71734d04b73f commit e7298f36f7912f2caa122086cfbe71734d04b73f Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Mon Feb 12 17:38:41 2018 [Telemetry] Shared state for Android Go stories Bug: chromium:787834 Bug: chromium:784319 Change-Id: I5fc2b452774d3dbf94f20e06ce53828b53520d6b Reviewed-on: https://chromium-review.googlesource.com/908457 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/core/platform.py [add] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/examples/benchmarks/android_go_benchmark.py [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py [add] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/examples/.gitignore [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/platform/platform_backend.py [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/platform/android_platform_backend.py [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/browser/browser.py [modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
,
Feb 13 2018
,
Feb 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/aa735864568706c37d39c5a59e4d4253cc48334c commit aa735864568706c37d39c5a59e4d4253cc48334c Author: Juan Antonio Navarro Perez <perezju@chromium.org> Date: Tue Feb 13 16:15:09 2018 [Telemetry] Clarify FindExistingBrowser docstring State explicitly that a BrowserGoneException is raised by FindExistingBrowser when no browser is found. Bug: chromium:784319 Change-Id: Ic394269f5350a33e303e114a4b7d6cf59c53da53 Reviewed-on: https://chromium-review.googlesource.com/916222 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/aa735864568706c37d39c5a59e4d4253cc48334c/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
,
Feb 14 2018
This one is done. Follow up for remaining cleanup work at issue 787834 .
,
Feb 14 2018
🎉🎉🎉 Finishing this is a huge milestone!
,
Feb 14 2018
woo hoo! Amazing! Thank you!!
,
Feb 20 2018
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
||||||||||||||||
►
Sign in to add a comment |
||||||||||||||||
Comment 1 by perezju@chromium.org
, Nov 13 2017