New issue
Advanced search Search tips

Issue 784319 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 786413
issue 792860
issue 801214
issue 801578

Blocking:
issue 780137



Sign in to add a comment

Create a Shared State for Android Go stories

Project Member Reported by perezju@chromium.org, Nov 13 2017

Issue description

The shared state should allow to launch Chrome from various other entry points (e.g. CCT app, PWA home screen shortcuts).
 
Labels: -Pri-3 Pri-1
Cc: -nednguyen@chromium.org nedngu...@google.com
Blockedon: 786413
Blockedon: 787468
Blockedon: 787500
Blockedon: 787834
Blockedon: -787500
Cc: pasko@chromium.org mattcary@chromium.org perezju@chromium.org
 Issue 795229  has been merged into this issue.
From Ned's comment #6 in the duped from bug:

> android_platform.LaunchApp('twitter')
> android_platform.Tap('id=....')  # -> this triggers CCT
> android_platform.WaitFor('id=...')  # Wait for CCT to appear on the screen
> alive_browsers = android_platform.GetAllRunningBrowserInstances()
> assert len(alive_browsers) == 1
> cct_browser = alive_browser[0]
> ... Do the rest of the user interaction with cct_browser ...

Note my current thinking is that rather than "GetAllRunningBrowserInstances", which could accidentally pick up some random browser we don't want, one would have a possible_browser instance (e.g. specifically for 'org.chromium.chrome') and do:

    browser = possible_browser.FindBrowserInstance()

to create the (Python) browser object from an already running browser instance on the device; rather than the current:

    browser = possible_browser.Create()  [1]

which both starts the instance and creates the corresponding browser object.

[1]: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py?rcl=846f7660e7d5004afac6052a9d7905695bc1edb7&l=196
Blockedon: 792860
Blockedon: 801214
Blockedon: 801578
Project Member

Comment 14 by bugdroid1@chromium.org, Feb 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/e7298f36f7912f2caa122086cfbe71734d04b73f

commit e7298f36f7912f2caa122086cfbe71734d04b73f
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Feb 12 17:38:41 2018

[Telemetry] Shared state for Android Go stories

Bug:  chromium:787834 
Bug:  chromium:784319 
Change-Id: I5fc2b452774d3dbf94f20e06ce53828b53520d6b
Reviewed-on: https://chromium-review.googlesource.com/908457
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Ned Nguyen <nednguyen@google.com>

[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/core/platform.py
[add] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/examples/benchmarks/android_go_benchmark.py
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py
[add] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/examples/.gitignore
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/platform/platform_backend.py
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/platform/android_platform_backend.py
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/browser/browser.py
[modify] https://crrev.com/e7298f36f7912f2caa122086cfbe71734d04b73f/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py

Blockedon: -787834
Project Member

Comment 16 by bugdroid1@chromium.org, Feb 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/aa735864568706c37d39c5a59e4d4253cc48334c

commit aa735864568706c37d39c5a59e4d4253cc48334c
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Tue Feb 13 16:15:09 2018

[Telemetry] Clarify FindExistingBrowser docstring

State explicitly that a BrowserGoneException is raised by
FindExistingBrowser when no browser is found.

Bug:  chromium:784319 
Change-Id: Ic394269f5350a33e303e114a4b7d6cf59c53da53
Reviewed-on: https://chromium-review.googlesource.com/916222
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[modify] https://crrev.com/aa735864568706c37d39c5a59e4d4253cc48334c/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py

Status: Fixed (was: Assigned)
This one is done. Follow up for remaining cleanup work at  issue 787834 .
🎉🎉🎉 Finishing this is a huge milestone!

Comment 19 by pasko@chromium.org, Feb 14 2018

woo hoo! Amazing! Thank you!!
Blockedon: -787468

Comment 21 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 22 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment