New issue
Advanced search Search tips

Issue 784313 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 784278
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

CL caused layout tests failure but changes were merged to W3C WPT repo: what is right action to take?

Project Member Reported by blundell@chromium.org, Nov 13 2017

Issue description

This CL: https://chromium-review.googlesource.com/c/chromium/src/+/765553 causes layout tests failures (e.g., https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Linux_Trusty%2F35746%2F%2B%2Frecipes%2Fsteps%2Fwebkit_layout_tests%2F0%2Fstdout).

I'm reluctant to revert this CL because changes that it made got merged to the W3C WPT repo; I don't know what the effect of reverting the CL in Chromium would be, and there don't seem to be instructions for this case on https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md.

For now I'm going to disable the test.
 
Mergedinto: 784278
Status: Duplicate (was: Assigned)

Sign in to add a comment