ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad browser_tests flaky on chromium.linux/Linux Tests |
||||
Issue descriptionThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad browser_tests flaky on chromium.linux/Linux Tests Builders failed on: - Linux Tests: https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests c.f. https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/64480 [ RUN ] ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad ../../chrome/browser/thumbnails/thumbnail_browsertest.cc:296: Failure Actual function call count doesn't match EXPECT_CALL(*thumbnail_service(), SetPageThumbnail(Field(&ThumbnailingContext::url, red_url), ImageColorIs(static_cast<SkColor>(0xFFFF0000))))... Expected: to be called once Actual: never called - unsatisfied and active [ FAILED ] ThumbnailTest.ShouldCaptureOnNavigatingAwaySlowPageLoad, where TypeParam = and GetParam() = (1956 ms)
,
Nov 13 2017
Win and Mac too. I'm on it.
,
Nov 13 2017
Pending CL: https://chromium-review.googlesource.com/c/chromium/src/+/765828
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2e420066973de57222dcdefc73de13c17981189 commit a2e420066973de57222dcdefc73de13c17981189 Author: Marc Treib <treib@chromium.org> Date: Mon Nov 13 14:47:56 2017 Thumbnail capturing: Try to deflake SlowPageLoad test This CL adds an explicit wait after the navigation to the page in question has finished, to give the renderer some time to actually paint it before we attempt to take a screenshot. Bug: 778248 , 784300 Change-Id: I2a0ecd73b6f182a064728d03a380d2ed40fa50f8 Reviewed-on: https://chromium-review.googlesource.com/765828 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515943} [modify] https://crrev.com/a2e420066973de57222dcdefc73de13c17981189/chrome/browser/thumbnails/thumbnail_browsertest.cc
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a2e420066973de57222dcdefc73de13c17981189 commit a2e420066973de57222dcdefc73de13c17981189 Author: Marc Treib <treib@chromium.org> Date: Mon Nov 13 14:47:56 2017 Thumbnail capturing: Try to deflake SlowPageLoad test This CL adds an explicit wait after the navigation to the page in question has finished, to give the renderer some time to actually paint it before we attempt to take a screenshot. Bug: 778248 , 784300 Change-Id: I2a0ecd73b6f182a064728d03a380d2ed40fa50f8 Reviewed-on: https://chromium-review.googlesource.com/765828 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515943} [modify] https://crrev.com/a2e420066973de57222dcdefc73de13c17981189/chrome/browser/thumbnails/thumbnail_browsertest.cc
,
Nov 13 2017
The above CL seems to have done it, no more flakes since it landed: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=ThumbnailTest |
||||
►
Sign in to add a comment |
||||
Comment 1 by tasak@google.com
, Nov 13 2017