New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784287 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Non-Regression: Toggle button in Do not Disturb Notification is not clickable

Project Member Reported by kebalaji@chromium.org, Nov 13 2017

Issue description

Chrome Version:64.0.3265.0/10123.0.0 dev-channel Gnawty,Blaze,Parrot
OS:Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Click on Notifications button
(2)Now click on settings buttons>> Click on Do not disturb toggle button from little distance(Refer video)

Expected: Toggle button should be clickable
Actual: Do not disturb toggle button is not clickable from little distance. It's clickable only when we click exactly on the button. If this is a intended, Other toggle buttons (Eg: Bluetooth in  ubertray etc.,) are clcikable even from a little distance.

This ia a Non-Regression issue seen from 63.0.3238.0/10028.0.0 (From the introduction of Do not disturb overlay)

@yoshiki: Please confrim the issue
 
ActualDonotdisturb.mp4
5.5 MB View Download
Cc: yoshiki@chromium.org
Owner: tetsui@chromium.org

Comment 2 by tetsui@chromium.org, Nov 14 2017

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ce482a26350b7afa7904a77bbaa5f2442e945df

commit 3ce482a26350b7afa7904a77bbaa5f2442e945df
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Wed Nov 15 01:55:00 2017

Enlarge do-not-disturb toggle button click target.

This CL adjusts paddings of do-not-disturb toggle button in notifier
settings, in order to make toggle button click target larger.
Previously, the padding was given to the container view, so this CL
splits the padding into three (container, label, toggle button).

TEST=manually tested, both in English and Hebrew (RTL)
BUG= 784287 

Change-Id: I847015fb513deb12b48aaa249bd4631f0650b920
Reviewed-on: https://chromium-review.googlesource.com/768315
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516557}
[modify] https://crrev.com/3ce482a26350b7afa7904a77bbaa5f2442e945df/ash/message_center/notifier_settings_view.cc

Comment 4 by tetsui@chromium.org, Nov 15 2017

Status: Fixed (was: Started)

Sign in to add a comment