Dino game doesn't work with touch
Reported by
espr...@gmail.com,
Nov 13 2017
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (X11; CrOS x86_64 10032.32.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.42 Safari/537.36 Steps to reproduce the problem: 1. Open chrome:dino 2. Touch the screen. 3. Game starts. 4. Try touching the screen to jump. 5. Lose :( What is the expected behavior? Touching the screen should jump like on android. What went wrong? Touching the screen starts the game, but the dino doesn't jump! :( Did this work before? N/A Chrome version: 63.0.3239.42 Channel: n/a OS Version: 10032.32.0 Flash Version:
,
Nov 17 2017
edwardjung owns this I think.
,
Feb 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/32846d9a75576a617c0a7e5866d13097bd22e416 commit 32846d9a75576a617c0a7e5866d13097bd22e416 Author: Edward Jung <edwardjung@chromium.org> Date: Mon Feb 12 23:33:42 2018 Allow offline dino easter egg to be playable via touch screen Check for touch enabled instead of detecting mobile. Hybrid CrOS and Windows devices can play the game via touch or keyboard. Also making the switch to listen to modern pointer events over mouse events. In future we wouldn't need to listen to touch events, but for now they are broken on older versions of iOS. Bug: 784279 Change-Id: Ifcda58ba681f51f9c279e4c128b4090feb464e16 Reviewed-on: https://chromium-review.googlesource.com/913450 Commit-Queue: Edward Jung <edwardjung@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536239} [modify] https://crrev.com/32846d9a75576a617c0a7e5866d13097bd22e416/components/neterror/resources/offline.js
,
Mar 1 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eaf5796e648b2b834c707655616fea91f811afd4 commit eaf5796e648b2b834c707655616fea91f811afd4 Author: Edward Jung <edwardjung@chromium.org> Date: Thu Mar 01 13:14:47 2018 chrome://dino improve hybrid device support Change the way touch is detected, so we listen to touch events regardless of device. The touch controller is added at the point the game is started with touch. This caters for hybrid devices, where the game could be started by keyboard or touch. Bug: 784279 Change-Id: Ie173825dbc4353a38444f864b39108d8e38e92c0 Reviewed-on: https://chromium-review.googlesource.com/939478 Reviewed-by: Julia Tuttle <juliatuttle@chromium.org> Commit-Queue: Edward Jung <edwardjung@chromium.org> Cr-Commit-Position: refs/heads/master@{#540141} [modify] https://crrev.com/eaf5796e648b2b834c707655616fea91f811afd4/components/neterror/resources/offline.js
,
Mar 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by weifangsun@chromium.org
, Nov 17 2017