New issue
Advanced search Search tips

Issue 784278 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

typedcssom/.../normalize-ident.html in webkit_layout_tests failing on multiple builders

Project Member Reported by tasak@google.com, Nov 13 2017

Issue description

Comment 1 by tasak@google.com, Nov 13 2017

Cc: haraken@chromium.org shend@chromium.org
Owner: hs1217....@samsung.com
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a450ecc3bbdd6a448a125d1d0e13361a0701e41d

commit a450ecc3bbdd6a448a125d1d0e13361a0701e41d
Author: Takashi SAKAMOTO <tasak@google.com>
Date: Mon Nov 13 09:51:54 2017

Mark typedcssom/stylevalue-normalization/normalize-ident.html as failing on multiple builders.

BUG= 784278 
TBR=dgozman

Change-Id: I79da59f309e7915b80f14cb882679f3788a245e3
Reviewed-on: https://chromium-review.googlesource.com/765640
Reviewed-by: Takashi Sakamoto <tasak@google.com>
Commit-Queue: Takashi Sakamoto <tasak@google.com>
Cr-Commit-Position: refs/heads/master@{#515907}
[modify] https://crrev.com/a450ecc3bbdd6a448a125d1d0e13361a0701e41d/third_party/WebKit/LayoutTests/TestExpectations

Oops, filed a dup. Adding my question from the bug that I filed:

I'm reluctant to revert this CL because changes that it made got merged to the W3C WPT repo; I don't know what the effect of reverting the CL in Chromium would be, and there don't seem to be instructions for this case on https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md.
Cc: hs1217....@samsung.com foolip@chromium.org
 Issue 784313  has been merged into this issue.
Status: Started (was: Assigned)
i will fix it as soon as possible.

i seems it is cause to merged stylevalue-normalization/normalize-ident.html between my CL passed CQ run dry and merged.
Labels: -Sheriff-Chromium
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9fd7240748f1ce00560946618f2bd0e9636d414

commit c9fd7240748f1ce00560946618f2bd0e9636d414
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Mon Nov 13 22:19:10 2017

[css-typed-om] Fix the normalize-ident.html LayoutTest failure

fix the normalize-ident.html LayoutTest failure.
normalize-ident.html seems like to merge between my patch
which is replaced with Element.attributeSytleMap
pass CQ dry run and merge.

Bug:  784278 ,  774933 
Change-Id: I779b6177399c3e10b6323b6ed891d81e523cfcfe
Reviewed-on: https://chromium-review.googlesource.com/765753
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#516079}
[modify] https://crrev.com/c9fd7240748f1ce00560946618f2bd0e9636d414/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c9fd7240748f1ce00560946618f2bd0e9636d414/third_party/WebKit/LayoutTests/typedcssom/stylevalue-normalization/normalize-ident.html

Status: Fixed (was: Started)

Sign in to add a comment