Regression:Blank username is seen on save password bubble for fb.com .
Reported by
pranjali...@etouch.net,
Nov 13 2017
|
||||||||||||||
Issue description
Chrome Version: 64.0.3265.0 (Official Build)630842eac3832f11f04f626774943de31b1ce35arefs /heads/master@{#515780}(64-bit)
OS:win(7,8,10),Mac(10.12.6,10.13.2),Linux(14.04 LTS)
URL:https://www.facebook.com/
Precondition:Sign into fb.com with valid credentials
Steps to reproduce:
1. Launch Chrome and click on ‘Account setting’ icon then select logout option.
2. Again sign into fb.com with valid credentials and click on save password key.
3. Observe username field on save password bubble.
Actual Result: Blank username is seen on save password bubble for second instance.
Expected Result:Username should not seen blank.
This is regression issue broken in ‘M-64’ and below per-revision bisect result
Using the per-revision bisect providing the bisect results,
Good Build: 64.0.3263.0
Bad Build: 64.0.3264.0
You are probably looking for a change made after 515264 (known good), but no later than 515265 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/d3a1dace85586cb7ca5611f66e7287cd72c4cc9d..bc80bd0bc8122c66c7a13c108137e2643754980e
Suspect:https://chromium.googlesource.com/chromium/src/+/bc80bd0bc8122c66c7a13c108137e2643754980e
,
Nov 13 2017
Adding Release blocker for this issue.Please remove if not the case. Thank You!
,
Nov 20 2017
Still we are able to reproduce the issue on Windows 7, mac 10.12.6 & ubuntu 14.04 as per C#0. M63 Stable promotion is coming VERY soon. Your bug is labelled as Stable blocker, please make sure to land the fix and request a merge into the release branch ASAP. Thank you.
,
Nov 20 2017
Is it reproducible in M63?
,
Nov 20 2017
jmukthavaram@: Is it reproducible in M63?
,
Nov 21 2017
Sorry for the confusion.Please ignore C#3. Thanks..!
,
Nov 21 2017
just to update: Above issue is still reproducible on latest canary build #64.0.3274.0 Please refer attached screen cast
,
Nov 22 2017
Above issue is working as intended on latest beta build #63.0.3239.59 and still reproducible on latest canary build #64.0.3274.0. Please refer attached screen cast. Thank you.
,
Nov 22 2017
+dvadym as kolos is OOO today
,
Nov 22 2017
I will fix it in M64 when come back.
,
Nov 28 2017
kolos@, Friendly ping to get an update on this issue. Thanks..!
,
Nov 28 2017
Work in progress
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53f4b0b854c735ca28e7cd580f2661784657c8e6 commit 53f4b0b854c735ca28e7cd580f2661784657c8e6 Author: Maxim Kolosovskiy <kolos@chromium.org> Date: Fri Dec 01 00:21:11 2017 [Password Manager] Values cached on page can be username Since https://chromium-review.googlesource.com/c/chromium/src/+/610080, if there is user input in form's fields, the fields without user input are ignored. It is not correct if the username is cached on page and the password typed by user. In this CL, non-passwords field w/o user input are ignored iff there are non-password (!) fields with user input. Bug: 784268 Change-Id: I4cdfc1af6d5d0823df95e5315934f3b4c25268fb Reviewed-on: https://chromium-review.googlesource.com/797035 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#520766} [modify] https://crrev.com/53f4b0b854c735ca28e7cd580f2661784657c8e6/chrome/browser/password_manager/password_generation_interactive_uitest.cc [modify] https://crrev.com/53f4b0b854c735ca28e7cd580f2661784657c8e6/components/autofill/content/renderer/password_form_conversion_utils.cc [modify] https://crrev.com/53f4b0b854c735ca28e7cd580f2661784657c8e6/components/autofill/content/renderer/password_form_conversion_utils_browsertest.cc
,
Dec 1 2017
,
Dec 1 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-64; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-64 label, otherwise remove Merge-TBD label. Thanks.
,
Dec 4 2017
As I understand, the fix was landed to M64 (https://chromium.googlesource.com/chromium/src/+/53f4b0b854c735ca28e7cd580f2661784657c8e6/chrome/VERSION). But the bot claims that the fix needs to be merged back.
,
Dec 5 2017
Your change meets the bar and is auto-approved for M64. Please go ahead and merge the CL to branch 3282 manually. Please contact milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 6 2017
It is already in M64. M64 includes commits till #520840. My commit is #520766. Gerrit UI fails to cherry pick and says "Cherry pick failed: identical tree"
,
Dec 8 2017
Removing Merge-TBD |
||||||||||||||
►
Sign in to add a comment |
||||||||||||||
Comment 1 by pranjali...@etouch.net
, Nov 13 2017