public/web/ needs a README |
|||
Issue descriptionSince Source/web/ is gone, it's confusing to have public/web/. Headers implemented by Source/core/ should move to public/core/. Headers implemented by Source/modules/ should move to public/modules/.
,
Nov 17 2017
Thanks. I'll send a PSA to blink-dev shortly.
,
Nov 30 2017
As dicussed on blik-dev [1], we won't split this directory for the time being because it won't solve the confusion between core vs modules and would also "leak" Blink's implementation structure to Blink's users. Instead we'll add README.md explaining this directory. Once Onion Soup is finished we can revisit what exactly to do with public/web/ if it's still around. CL for README: https://chromium-review.googlesource.com/#/c/chromium/src/+/798490 [1] - https://groups.google.com/a/chromium.org/d/msg/blink-dev/InNI54L0GZ0/fqugGnFuCAAJ
,
Dec 14 2017
haraken@ has taken over this issue: https://chromium-review.googlesource.com/c/chromium/src/+/823863
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d5c6ad260ab5598516a1b21c5175d3daf8673454 commit d5c6ad260ab5598516a1b21c5175d3daf8673454 Author: Kentaro Hara <haraken@chromium.org> Date: Fri Dec 15 04:16:51 2017 Add WebKit/Source/README.md Bug: 784252 Change-Id: Iaf2c709ddd12134382a621205d3b34b08474f86e Reviewed-on: https://chromium-review.googlesource.com/823863 Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by: Philip Jägenstedt <foolip@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#524321} [modify] https://crrev.com/d5c6ad260ab5598516a1b21c5175d3daf8673454/third_party/WebKit/Source/OWNERS [add] https://crrev.com/d5c6ad260ab5598516a1b21c5175d3daf8673454/third_party/WebKit/Source/README.md [modify] https://crrev.com/d5c6ad260ab5598516a1b21c5175d3daf8673454/third_party/WebKit/public/README.md |
|||
►
Sign in to add a comment |
|||
Comment 1 by lucmult@chromium.org
, Nov 17 2017