New issue
Advanced search Search tips

Issue 784236 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

PointerLockBrowserTest.PointerLockEventRouting flaky

Project Member Reported by tasak@google.com, Nov 13 2017

Issue description

PointerLockBrowserTest.PointerLockEventRouting is flaky on chromium.mac/Mac10.9/10/11 Tests

Builders failed on: 
- Mac10.10 Tests: 
  https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests
- Mac10.9 Tests:
 https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/50143
- Mac10.11 Tests:
 https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests/builds/20258

Suspect CL is r515875.

 
Labels: -OS-Mac
Summary: PointerLockBrowserTest.PointerLockEventRouting flaky (was: PointerLockBrowserTest.PointerLockEventRouting content_unittests flaky on chromium.mac/Mac Tests)
Linux TSAN as well: https://build.chromium.org/p/chromium.memory/builders/Linux%20TSan%20Tests/builds/14127 for example.

The reason for suspecting this CL is that the flakiness on Mac10.10 started on a build that only had this CL on it, and on no bot do we see this flake *before* this CL landed.

Unfortunately the logs from the failing builds inexplicably have no information. I'm going to revert the suspected CL to see if the flake disappears; if the flake is still there I'll reland it (or feel free to reland yourself if it's after EU working hours and you see that the flake is still there).
Labels: -Sheriff-Chromium
Revert landed in https://chromium-review.googlesource.com/c/chromium/src/+/765847. Taking this off the sheriff queue unless we see that the flake is still there.

Comment 4 by kenrb@chromium.org, Nov 13 2017

Cc: lfg@chromium.org
Lucas, can you look at this? One of your pointer lock tests became flaky when I landed OOPIF frame throttling.

Do you think the test just needs a call to WaitForChildFrameSurfaceReady()? I haven't been able to reproduce the flake locally so it's hard to verify.

Comment 5 by lfg@chromium.org, Nov 13 2017

That seems plausible. If we get to here https://cs.chromium.org/chromium/src/content/browser/pointer_lock_browsertest.cc?l=257 before the child frame has submitted a frame the test would fail. And there's nothing before that that would guarantee that the child has submitted a frame.

The only thing that I'm a bit worried is that the test times out in ExecuteScriptAndExtractInt(). This happens immediately after MainThreadFrameObserver, which implies the rendere was/is alive at the time. I'm not sure why ExecuteScript would fail.

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/967badcc77752201fa0e6c68524af2d9434efd1f

commit 967badcc77752201fa0e6c68524af2d9434efd1f
Author: Ken Buchanan <kenrb@chromium.org>
Date: Tue Nov 14 22:15:57 2017

Reland: Enable render throttling for OOPIFs

Originally landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/719601

The change caused a racy test to flake on Mac and was reverted. This
patch restores the original CL and fixes the cause of the flakiness in
the problematic test.

TBR=dcheng@chromium.org

Bug:  761478 ,  784236 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I0a4da143505b60ce21083413f741e4fe24b0db42
Reviewed-on: https://chromium-review.googlesource.com/769489
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516454}
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/common/frame_messages.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/common/view_messages.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_widget.cc
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/content/renderer/render_widget.h
[add] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html
[add] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClient.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/967badcc77752201fa0e6c68524af2d9434efd1f/third_party/WebKit/public/web/WebRemoteFrameClient.h

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814

commit e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814
Author: Dirk Pranke <dpranke@chromium.org>
Date: Wed Nov 15 00:33:03 2017

Revert "Reland: Enable render throttling for OOPIFs"

This reverts commit 967badcc77752201fa0e6c68524af2d9434efd1f.

Reason for revert: looks like content_browsertests failing on chromium.mac/Mac10.10 Tests in PointerLockBrowserTest.PointerLockEventRouting and this might be the culprit

Original change's description:
> Reland: Enable render throttling for OOPIFs
> 
> Originally landed here:
> https://chromium-review.googlesource.com/c/chromium/src/+/719601
> 
> The change caused a racy test to flake on Mac and was reverted. This
> patch restores the original CL and fixes the cause of the flakiness in
> the problematic test.
> 
> TBR=dcheng@chromium.org
> 
> Bug:  761478 ,  784236 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: I0a4da143505b60ce21083413f741e4fe24b0db42
> Reviewed-on: https://chromium-review.googlesource.com/769489
> Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
> Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> Commit-Queue: Ken Buchanan <kenrb@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#516454}

TBR=kenrb@chromium.org,alexmos@chromium.org

Change-Id: I6d35267d8b5eb361ccc56bd62148edc6acb7dd14
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  761478 ,  784236 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Reviewed-on: https://chromium-review.googlesource.com/770270
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516520}
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/common/frame_messages.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/common/view_messages.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_widget.cc
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/content/renderer/render_widget.h
[delete] https://crrev.com/576ff94f80108eaf2c8fed6780a629f36e49b4a5/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html
[delete] https://crrev.com/576ff94f80108eaf2c8fed6780a629f36e49b4a5/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClient.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/e3f0c8e1e67904bfa909dddb4ed4f97df3ddf814/third_party/WebKit/public/web/WebRemoteFrameClient.h

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9

commit 8a319fbc7039bf38fe46bf7c5f78cca4e82206b9
Author: Ken Buchanan <kenrb@chromium.org>
Date: Wed Nov 15 18:37:12 2017

Reland: Enable render throttling for OOPIFs

Originally landed here:
https://chromium-review.googlesource.com/c/chromium/src/+/719601

The change caused a racy test to flake on Mac and was reverted. This
patch restores the original CL and fixes the cause of the flakiness in
the problematic test.

Was earlier relanded with a fix to only one of the two tests that had
race conditions.

TBR=dcheng@chromium.org

Bug:  761478 ,  784236 ,  785080 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I947a70b256b0783b2c687c1213c6e00fe06550a8
Reviewed-on: https://chromium-review.googlesource.com/771773
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516758}
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/frame_host/cross_process_frame_connector.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/pointer_lock_browsertest.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/frame_connector_delegate.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/browser/renderer_host/render_widget_host_view_child_frame.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/frame_messages.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/common/view_messages.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_frame_proxy.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.cc
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/content/renderer/render_widget.h
[add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/raf-throttling-out-of-view-cross-origin-page.html
[add] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/LayoutTests/http/tests/dom/resources/raf-throttling-frame.html
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClient.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/RemoteFrameView.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/Source/core/loader/EmptyClients.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebFrameWidget.h
[modify] https://crrev.com/8a319fbc7039bf38fe46bf7c5f78cca4e82206b9/third_party/WebKit/public/web/WebRemoteFrameClient.h

Comment 9 by kenrb@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)

Sign in to add a comment