Issue metadata
Sign in to add a comment
|
Profile switcher has no keyboard focus highlight |
||||||||||||||||||||||||
Issue descriptionChrome Version : 64.0.3265.0 What steps will reproduce the problem? 1. Click profile switcher button, menu shows 2. Press Tab What is the expected result? Menu items should cycle through, either highlighting grey (old Windows behavior) or drawing a blue focus ring around the edges (old Mac behavior) What happens instead of that? No focus ring. Only the "Sign In" button shows focus, if it is present. Probably a regression from r515443
,
Nov 13 2017
Merging this into issue 784244 since it has videos for more context.
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5226572e47a75c4a7cce7c4d9dab05a375556043 commit 5226572e47a75c4a7cce7c4d9dab05a375556043 Author: Patti <patricialor@chromium.org> Date: Mon Nov 13 08:19:17 2017 Profile Chooser: Show ink drop highlight when buttons are focused. r515443 swapped out the custom higlighting in the Profile Chooser for ink drops instead. However, this introduced a regression where the buttons would no longer highlight on focus. Fix by turning on highlight on focus mode for ink drops. Bug: 784235 Change-Id: Ib45cbbc82644279496bbab42e97406de96b4db7c Reviewed-on: https://chromium-review.googlesource.com/765612 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#515900} [modify] https://crrev.com/5226572e47a75c4a7cce7c4d9dab05a375556043/chrome/browser/ui/views/hover_button.cc
,
Nov 16 2017
Tested this issue on Mac 10.12.6 with chrome #64.0.3269.3 Observed that on clicking the profile switcher button and again pressing tabs it is not focusing on the menu options. Attaching the screen-cast for reference. patricialor@ Could you please look into it and let us confirm this is the expected behavior of this fix Thank You...
,
Nov 16 2017
Try 64.0.3270.0, I just tried on that and tabbing through the menu options will highlight the currently focused one. But the video you uploaded in #c4 should not be the fixed behaviour. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by patricia...@chromium.org
, Nov 13 2017Status: Started (was: Assigned)