New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784226 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

[desktop-pwas] Title flashes with URL before first page load

Project Member Reported by calamity@chromium.org, Nov 13 2017

Issue description

The Desktop PWA frame flashes with the load URL before the first page load. This is ugly and breaks the app immersion.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec

commit 772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec
Author: Christopher Lam <calamity@chromium.org>
Date: Tue Nov 14 08:23:59 2017

[desktop-pwas] Stop showing URL as title on page load.

This CL fixes an issue where Desktop PWAs would show their URLs before
the page had loaded due to the implementation of
NavigationEntry::GetTitleForDisplay(). This has been fixed by adding a
GetTitle() to HostedAppBrowserController which uses
NavigationEntry::GetTitle() instead.

Bug:  784226 
Change-Id: I7bb8bf32026cf2b623ecaa2aa278a73fe23b6250
Reviewed-on: https://chromium-review.googlesource.com/765560
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516232}
[modify] https://crrev.com/772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec/chrome/browser/ui/browser.cc
[modify] https://crrev.com/772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec/chrome/browser/ui/extensions/hosted_app_browser_controller.cc
[modify] https://crrev.com/772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec/chrome/browser/ui/extensions/hosted_app_browser_controller.h
[modify] https://crrev.com/772a4c2c7aeb03c5b58707bd3ab34d9d61cd19ec/chrome/browser/ui/extensions/hosted_app_browsertest.cc

Status: Fixed (was: Started)

Comment 3 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 4 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment