New issue
Advanced search Search tips

Issue 784223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 10
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 811523



Sign in to add a comment

Investigate the SkImage cache policy in SkiaRenderer and SoftwareRender

Project Member Reported by xing...@intel.com, Nov 13 2017

Issue description

Currently  resource_sk_image_ may keep caching and cache's size would grow
indefinitely. This may lead to out of memory. In the future, to really enable cache, we have to either have a limit or try to remove expired SkImage.

This bugs is originated from:
https://chromium-review.googlesource.com/c/chromium/src/+/749102(Reverted here:
https://chromium-review.googlesource.com/c/chromium/src/+/765174)

And about the out of memory case:
https://bugs.chromium.org/p/chromium/issues/detail?id=783754
 

Comment 1 by danakj@chromium.org, Nov 14 2017

Status: Assigned (was: Untriaged)
Blocking: 811523
Owner: bsalo...@google.com
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4dabf440fb51d1901b2ae1f5beec74f6696deca

commit f4dabf440fb51d1901b2ae1f5beec74f6696deca
Author: Brian Salomon <bsalomon@google.com>
Date: Wed Oct 10 20:46:51 2018

Cache SkImage in DisplayResourceProvider's resource_sk_image_ map.

Remove when looping over unused resources in
DeleteAndReturnUnusedResourcesToChild

Bug:  784223 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I7b960dcc7d4564bd869e6c661e6a08ea469a54da
Reviewed-on: https://chromium-review.googlesource.com/c/1273807
Reviewed-by: weiliangc <weiliangc@chromium.org>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Cr-Commit-Position: refs/heads/master@{#598489}
[modify] https://crrev.com/f4dabf440fb51d1901b2ae1f5beec74f6696deca/components/viz/service/display/display_resource_provider.cc

Status: Fixed (was: Assigned)

Sign in to add a comment