[css-typed-om] CSSRotation should take Numberishes |
||||||
Issue descriptionCSSRotation currently only takes CSSNumericValues. It should also be able to take raw doubles (Numberishes). Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssrotation
,
Nov 14 2017
Thanks! Just so we don't clash, I'm adding layout tests for CSSScale and CSSRotation as part of crbug.com/774887 . The patches should land soon.
,
Nov 16 2017
,
Nov 27 2017
,
Dec 1 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/730c6336eb93bf5d1dd94c6f97c2b8433b348ede commit 730c6336eb93bf5d1dd94c6f97c2b8433b348ede Author: nikhil <nikhil.sahni@samsung.com> Date: Fri Dec 01 06:32:53 2017 [css-typed-om] CSSRotation should take Numberishes. CSSRotation currently only takes CSSNumericValues. It should also be able to take raw doubles (Numberishes). Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssrotation Bug: 784217 Change-Id: Ic4736ff2ca2d54023d38c8eceb0a44fd3a68b557 Reviewed-on: https://chromium-review.googlesource.com/768583 Commit-Queue: NIKHIL SAHNI <nikhil.sahni@samsung.com> Reviewed-by: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#520876} [modify] https://crrev.com/730c6336eb93bf5d1dd94c6f97c2b8433b348ede/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssRotation-expected.txt [modify] https://crrev.com/730c6336eb93bf5d1dd94c6f97c2b8433b348ede/third_party/WebKit/LayoutTests/typedcssom/stylevalue-subclasses/cssRotation.html [modify] https://crrev.com/730c6336eb93bf5d1dd94c6f97c2b8433b348ede/third_party/WebKit/Source/core/css/cssom/CSSRotation.cpp [modify] https://crrev.com/730c6336eb93bf5d1dd94c6f97c2b8433b348ede/third_party/WebKit/Source/core/css/cssom/CSSRotation.h [modify] https://crrev.com/730c6336eb93bf5d1dd94c6f97c2b8433b348ede/third_party/WebKit/Source/core/css/cssom/CSSRotation.idl
,
Dec 6 2017
,
Jan 15 2018
Can we close this now?
,
Jan 16 2018
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by nikhil.s...@samsung.com
, Nov 14 2017