Fix android specific crash in android bot_hook |
||
Issue description
The android specific bot hooks is a leading source in crash reports. :D
Reducing the noise, at least for the few top contributors, would help managing the error stream and help uncover actual failures as they currently get drown out in the noise.
The leading source of crashs is:
File "swarming_bot.2.zip/api/os_utilities.py", line 978, in fn
u'disk': device.GetDisk(),
File "swarming_bot.2.zip/adb/contrib/high.py", line 755, in GetDisk
u'cache': props[u'Cache-Free'],
KeyError: u'Cache-Free'
This should be a simple fix in high.py but we'll likely find following crashes after that. You can monitor these at:
https://console.cloud.google.com/errors?project=chromium-swarm
(I'm working on the other errors on that page separately)
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/python-adb/+/4b578d9eb95f7fa01a2b2ed123c66152f6c524ae commit 4b578d9eb95f7fa01a2b2ed123c66152f6c524ae Author: Benjamin Pastene <bpastene@chromium.org> Date: Tue Nov 14 20:11:11 2017 py-adb: Detect another type of dumpsys error. R=maruel@chromium.org Bug: 784197 Change-Id: I891bc039450904f0d5d06daf96596b57a62cf894 Reviewed-on: https://chromium-review.googlesource.com/769344 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/4b578d9eb95f7fa01a2b2ed123c66152f6c524ae/adb/contrib/high.py
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/luci-py.git/+/b7e4c85ae01f0e0590b340535eb550fa5282430e commit b7e4c85ae01f0e0590b340535eb550fa5282430e Author: Benjamin Pastene <bpastene@chromium.org> Date: Tue Nov 14 20:16:31 2017 swarming: Roll py-adb to pick up dumpsys fix. TBR=maruel@chromium.org Bug: 784197 Change-Id: Ib95efd516267b6e2a4ef75a64e6121a916639540 Reviewed-on: https://chromium-review.googlesource.com/769439 Reviewed-by: Benjamin Pastene <bpastene@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> [modify] https://crrev.com/b7e4c85ae01f0e0590b340535eb550fa5282430e/appengine/third_party/python-adb/README.swarming [modify] https://crrev.com/b7e4c85ae01f0e0590b340535eb550fa5282430e/appengine/third_party/python-adb/adb/contrib/high.py
,
Nov 17 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/b7966120b2ddd22b9e87003fe56387c481126cfe commit b7966120b2ddd22b9e87003fe56387c481126cfe Author: Benjamin Pastene <bpastene@chromium.org> Date: Fri Nov 17 18:19:54 2017
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/luci/python-adb/+/135dd71bfa85b2b1a497c80b4c4d4953dd3af37a commit 135dd71bfa85b2b1a497c80b4c4d4953dd3af37a Author: Benjamin Pastene <bpastene@chromium.org> Date: Mon Nov 20 20:00:05 2017 py-adb: Swallow InvalidResponseError when rooting. R=maruel@chromium.org Bug: 784197 Change-Id: Ic07893b9e579c1190faad538ee5099a9ea3e7c88 Reviewed-on: https://chromium-review.googlesource.com/777000 Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org> [modify] https://crrev.com/135dd71bfa85b2b1a497c80b4c4d4953dd3af37a/adb/contrib/adb_commands_safe.py
,
Nov 29 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/029c964e4b05827ddef14e701eeb5b4aa13a059a commit 029c964e4b05827ddef14e701eeb5b4aa13a059a Author: Benjamin Pastene <bpastene@chromium.org> Date: Wed Nov 29 21:18:55 2017
,
Nov 30 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/227352cdfb0815ebab36272c1c609d40b6de9e1d commit 227352cdfb0815ebab36272c1c609d40b6de9e1d Author: Benjamin Pastene <bpastene@chromium.org> Date: Thu Nov 30 23:49:08 2017
,
Dec 1 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/ed72b790a63e7aca77db3bc3d05fb31d34c866b0 commit ed72b790a63e7aca77db3bc3d05fb31d34c866b0 Author: Benjamin Pastene <bpastene@chromium.org> Date: Fri Dec 01 22:13:47 2017
,
Dec 4 2017
All the bot_config crashes should be fixed. In the past 24 hours, there's been ~20 device transmission errors, all of which I feel safe in attributing to race-conditions/general packet/device flakiness in adb. Not much we can really do there. I'm going to close this out. If anyone wants those additional errors fixed as well, feel free to reopen. But for now, I don't think it's worth the effort.
,
Dec 5 2017
Thanks! |
||
►
Sign in to add a comment |
||
Comment 1 by bpastene@chromium.org
, Nov 13 2017Status: Assigned (was: Unconfirmed)