New issue
Advanced search Search tips

Issue 784181 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug-Regression

Blocking:
issue angleproject:2169



Sign in to add a comment

14.4%-14.6% regression in angle_perftests at 515817:515837

Project Member Reported by jmadill@google.com, Nov 12 2017

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 12 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=784181

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=abb1ba3bc360ec19a98bd1eb15c0379ca500e4deb7bb27d1a2ab950cee5636c2


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
Components: Internals>GPU>ANGLE
Labels: OS-Windows
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Nov 12 2017

Cc: cwallez@chromium.org
Owner: cwallez@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author cwallez@chromium.org ===

Hi cwallez@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Corentin Wallez
  Commit : 336129f66f63938212ca0f7069d1a5e483f02042
  Date   : Fri Nov 10 23:18:12 2017
  Subject: Use a packed enum for buffer targets.

Bisect Details
  Configuration: winx64nvidia_perf_bisect
  Benchmark    : angle_perftests
  Metric       : Bindings_d3d11_100_objects_allocated_at_initialization/score
  Change       : 14.72% | 2465.83333333 -> 2102.83333333

Revision                              Result                  N
chromium@515816                       2465.83 +- 18.1888      6      good
chromium@515818                       2442.67 +- 112.193      6      good
chromium@515818,angle@336129f66f      2085.33 +- 37.3006      6      bad       <--
chromium@515819                       2086.67 +- 26.5957      6      bad
chromium@515822                       2079.33 +- 16.5932      6      bad
chromium@515827                       2095.0 +- 42.5441       6      bad
chromium@515837                       2102.83 +- 37.747       6      bad

To Run This Test
  .\src\out\Release_x64\angle_perftests.exe --test-launcher-print-test-stdio=always --test-launcher-jobs=1

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963126929107692464


For feedback, file a bug with component Speed>Bisection
Status: Fixed (was: Assigned)
This has been mostly fixed with a tiny regression still remaining.
Blocking: angleproject:2169
Very nice work on this.

Sign in to add a comment