New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 784179 link

Starred by 1 user
Status: Assigned
Owner:
█ brettw@chromium.org
Last visit 25 days ago
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

gn check complains "Include is not allowed" on non-chromeos build for an #include which is guarded by OS_CHROMEOS

Project Member Reported by penghuang@chromium.org, Nov 12 2017 
See [1], the include is in side #if defined(OS_CHROMEOS) block. the gn check shouldn't complains it. But it complains to as:


[1] https://chromium-review.googlesource.com/c/chromium/src/+/759092/12/chrome/browser/ui/views/toolbar/toolbar_view.hgn check out/linux_chromium
ERROR at //chrome/browser/ui/views/toolbar/toolbar_view.h:30:11: Include not allowed.
#include "components/arc/common/intent_helper.mojom.h"
          ^------------------------------------------
It is not in any dependency of
  //chrome/browser/ui:ui
The include file is in the target(s):
  //components/arc/common:common
  //components/arc/common:common__generator
at least one of which should somehow be reachable.
Makefile:297: recipe for target 'check_chromium' failed
make: *** [check_chromium] Error 1

Comment 1 by penghuang@chromium.org, Nov 12 2017

Owner: brettw@chromium.org
Wrong link. The right link should be 
[1] https://chromium-review.googlesource.com/c/chromium/src/+/759092/12/chrome/browser/ui/views/toolbar/toolbar_view.h

brettw@ could you please take a look this gn issue? Thanks.

Comment 2 by msw@chromium.org, Nov 13 2017 

The CL necessitating the new // nogncheck is:
  https://chromium-review.googlesource.com/c/chromium/src/+/759092
It moves the //components/arc:arc_bindings mojom target to //components/arc/common, but keeps that as a public dep of the //components/arc:arc_base static_library target, which is a public dep of the //components/arc static_library target, which is indeed a dependency of the //chrome/browser/ui split_static_library target if (is_chromeos)...

Comment 3 by benhenry@chromium.org, Aug 1

Status: Assigned (was: Untriaged)
►

Sign in to add a comment