New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 784135 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect "low power charger" notification for samus on USB-C

Project Member Reported by jamescook@chromium.org, Nov 12 2017

Issue description

"Low power charger connected" but I'm on an Apple 87W USB-C adapter through a Google techstop USB-C to USB-C cable. Something seems wrong here.

http://feedback/#/Report/84642171468

This happened, I rebooted then got the notification again. Unplugging and replugging the cable made it go away and now things are charging normally.

Google Chrome	63.0.3239.42 (Official Build) beta (64-bit)
Platform	10032.32.0 (Official Build) beta-channel samus
Firmware Version	Google_Samus.6300.174.0

 

Comment 1 by derat@chromium.org, Nov 12 2017

Cc: bleung@chromium.org tbroch@chromium.org snanda@chromium.org
Components: OS>Firmware>EC
Here's powerd.LATEST:

[1111/182244:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.4V, max 2.4A at 5.0V) with battery at 41%, 3.763/9.161Ah at 0.367A, 0s until full (calculating)
[1111/182244:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.4V, max 2.4A at 5.0V) with battery at 41%, 3.763/9.161Ah at 0.367A, 0s until full (calculating)
[1111/182247:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.6V, max 2.4A at 5.0V) with battery at 41%, 3.762/9.161Ah at 2.077A, 0s until empty (calculating)
[1111/182254:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.5V, max 2.4A at 5.0V) with battery at 41%, 3.759/9.161Ah at 1.125A, 3h20m27s until empty (3h55s until shutdown)
[1111/182313:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.6V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.196A
[1111/182317:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.6V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.204A, 9h55m13s until empty (8h57m6s until shutdown)
[1111/182318:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.7V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.133A
[1111/182324:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.7V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.035A, 18h2m33s until empty (16h16m51s until shutdown)
[1111/182344:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.6V, max 2.4A at 5.0V) with battery at 41%, 3.752/9.161Ah at 0.127A
[1111/182346:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.6V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.703A, 16h16m38s until empty (14h41m17s until shutdown)
[1111/182348:INFO:daemon.cc(771)] On USB (USB_PD, 0.000A at 4.7V, max 2.4A at 5.0V) with battery at 41%, 3.753/9.161Ah at 0.223A

powerd's usb_min_ac_watts pref defaults to 20 W.

Comment 2 by bleung@chromium.org, Nov 12 2017

Cc: sha...@chromium.org bleung@google.com
NextAction: 2017-11-13
Owner: bleung@chromium.org
Status: Assigned (was: Untriaged)
I'll take a look.

I suspect some low level issue between the Apple 87W adapter, it's fancy cable, and the samus's pd controller.

Comment 3 by bleung@chromium.org, Nov 12 2017

This combination should result in 60W charging, but it looks like Samus stops at the 12W initial offering from the charger.
The NextAction date has arrived: 2017-11-13

Comment 5 by bleung@chromium.org, Nov 13 2017

Cc: phillipmolina@google.com

Comment 6 by bleung@chromium.org, Nov 13 2017

James mentioned in an email that he's using the 87W adapter with a StarTech C-to-C cable he got from techstop. Only tried it on left port, doesn't happen every time. After a couple of replugs and a reboot, it started working.

Comment 7 by bleung@chromium.org, Nov 16 2017

NextAction: ----
Owner: sha...@chromium.org
Ok, I was able to reproduce it. It looks like something falls down in the protocol level, as Samus doesn't respond when the power source sends its second SRCCAP.

Captured my own feedback report here: https://listnr.corp.google.com/report/84650784993

Shawnn, can I get your opinion on this?
87W Apple + 3A cable + Samus. 12W charging only.tdc
151 KB Download

Comment 8 by tbroch@chromium.org, Nov 16 2017

Cc: vpalatin@chromium.org
Attaching csv of tdc for those who may not have totalphase 'data center' tools.

# Level,Spec,Index,m:s.ms.us,Dur,Len,Err,CC,Role,Message,Data
...
0,v2.0,1269,0:24.608.601,630.000 us,10 B,,1,Source:DFP,[0]Source_Cap,61 11 F0 90 01 08 4A D4 5F 43
0,v2.0,1273,0:24.610.285,630.000 us,10 B,,1,Source:DFP,[0]Source_Cap,61 11 F0 90 01 08 4A D4 5F 43
0,v2.0,1277,0:24.611.864,629.000 us,10 B,,1,Source:DFP,[0]Source_Cap,61 11 F0 90 01 08 4A D4 5F 43
0,,1281,0:24.590.129,,,,2,,PD,
0,v2.0,1282,0:24.613.544,629.000 us,10 B,,1,Source:DFP,[0]Source_Cap,61 11 F0 90 01 08 4A D4 5F 43
0,v2.0,1286,0:24.723.990,630.000 us,10 B,,1,Source:DFP,[1]Source_Cap,61 13 F0 90 01 08 2A 87 9F 39
0,,1290,0:24.724.588,512.000 us,6 B,,1,Sink:UFP,[1]GoodCRC,41 02 97 0D B5 46
0,v2.0,1293,0:24.725.469,645.000 us,10 B,,1,Sink:UFP,[0]Request,42 10 F0 C0 03 14 1F 9A 8C B5
0,,1297,0:24.725.922,,,,1,,PD,
0,,1298,0:24.726.133,493.000 us,6 B,,1,Source:DFP,[0]GoodCRC,61 01 8F 78 38 4A
0,v2.0,1301,0:24.727.101,493.000 us,6 B,,1,Source:DFP,[2]Accept,63 05 14 DE 63 7F
0,,1304,0:24.727.755,508.000 us,6 B,,1,Sink:UFP,[2]GoodCRC,41 04 A2 A8 D6 AF
0,v2.0,1307,0:24.755.801,497.000 us,6 B,,1,Source:DFP,[3]PS_RDY,66 07 7D 4B 1A EC
0,,1310,0:24.756.320,509.000 us,6 B,,1,Sink:UFP,[3]GoodCRC,41 06 8E C9 D8 41
0,v2.0,1313,0:24.776.073,895.000 us,18 B,,1,Source:DFP,[4]Source_Cap,61 39 F0 90 01 08 2C D1 02 00 2C 41 06 00 2D A8 46 AA
0,v2.0,1319,0:24.777.916,895.000 us,18 B,,1,Source:DFP,[4]Source_Cap,61 39 F0 90 01 08 2C D1 02 00 2C 41 06 00 2D A8 46 AA
0,,1325,0:24.778.827,,,,1,,PD,
0,v2.0,1326,0:24.779.867,895.000 us,18 B,,1,Source:DFP,[4]Source_Cap,61 39 F0 90 01 08 2C D1 02 00 2C 41 06 00 2D A8 46 AA
0,v2.0,1332,0:24.781.814,895.000 us,18 B,,1,Source:DFP,[4]Source_Cap,61 39 F0 90 01 08 2C D1 02 00 2C 41 06 00 2D A8 46 AA
...
0,v2.0,2534,0:30.485.695,895.000 us,18 B,,1,Source:DFP,[5]Source_Cap,61 3B F0 90 01 08 2C D1 02 00 2C 41 06 00 66 1D 1A CA
0,,2540,3:50.986.673,,,,,,Capture stopped,[Mon Nov 13 16:08:36 2017]

Seems like collisions on CC as SRC sends more src caps & I'm guessing sink is in PD_STATE_SNK_READY and also active on CC

+Vincent as well.
87W Apple + 3A cable + Samus. 12W charging only.csv
63.6 KB View Download

Comment 9 by sha...@chromium.org, Nov 18 2017

On the PD MCU side, we see repeated Rx errors, from the second burst of source caps, right after getting PS_RDY:

[876.695663 Ramp reset: st1]
[876.695868 New ilim 2400]
[876.696122 CL: p1 s0 i2400 v5000]
+ERR len:
000:- 0 37 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 
032:1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 
064:1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 2 2 1 1 1 1 2 2 
096:2 1 1 1 1 2 2 2 1 1 1 1 1 1 2 2 2 1 1 1 1 2 2 1 1 2 2 1 1 1 1 1 
128:1 2 1 1 1 1 2 2 1 1 1 1 2 1 1 2 1 1 2 1 1 1 1 1 1 1 1 1 1 2 1 1 
160:1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 1 1 1 1 2 2 1 1 2 2 1 1 1 
192:1 1 1 1 1 2 1 1 2 2 1 1 2 1 1 1 1 1 1 1 1 2 1 1 2 1 1 1 1 2 2 1 
224:1 2 1 1 1 1 2 2 1 1 2 
000:6e 6e 01 0a 0d 11 19 1d 21 29 2c 31 38 3d 40 49 4c 51 58 5d 60 69 6c 71 78 7c 80 88 8c 90 98 9c 
032:9f a8 ab b0 b7 bc bf c8 cb d0 d7 dc df e8 eb ef f7 fb ff 07 0a 0f 16 1b 1e 27 2a 2f 36 3b 3e 47 
064:4a 4f 56 5b 5e 66 6a 6e 76 7a 7d 86 89 8e 95 9a 9d a6 a9 ae b5 ba bd c6 cd d6 d9 dd e1 e5 ed f5 
096:fc 01 04 09 0c 15 1c 25 28 2d 30 35 38 3d 44 4d 54 58 5b 60 63 6c 73 78 7b 84 8b 90 93 98 9b a0 
128:a3 ac af b4 b7 bc c2 cb ce d3 d6 db e2 e7 ea f3 f6 fb 02 07 0a 0f 12 17 1a 1f 22 27 2a 32 36 3a 
160:3ae 
544:b2 ba c1 c6 c9 ce d1 d6 d9 e2 e5 ea ed f2 f9 02 05 0a 0d 12 19 1d 20 29 2c 31 38 [876.812164 HC 0x103]
[876.819421 HC 0x113]
[876.827205 HC 0x103]
[876.833206 PD TMOUT RX 416/416]
ERR Preamble:
000:- 0 52 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 
032:1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 
064:1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 2 2 1 1 1 1 2 2 
096:2 1 1 1 1 2 2 2 1 1 1 1 1 1 2 2 2 1 1 1 1 2 2 1 1 2 2 1 1 1 1 1 
128:1 2 1 1 1 1 1 1 2 1 1 1 1 2 1 1 2 1 1 2 1 1 1 1 1 1 1 1 1 1 2 1 
160:1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 1 1 1 1 2 2 1 1 2 2 1 1 
192:1 1 1 1 1 1 2 1 1 2 2 1 1 2 1 1 1 1 1 1 1 1 2 1 1
000:30 30 01 0a 0d 12 18 1d 20 29 2c 31 38 3d 40 49 4c 51 58 5d 60 69 6c 71 78 7d 7f 88 8b 90 97 9c 
032:9f a8 ab b0 b7 bc bf c8 cb d0 d7 dc df e8 ea ef f6 fb fe 07 0a 0f 16 1b 1e 27 2a 2f 36 3b 3e 47 
064:4a 4f 56 5a 5d 66 69 6e 75 7a 7d 86 89 8e 95 9a 9d a6 a9 ae b5 ba bd c6 cc d5 d8 dd e0 e5 ec f5 
096:fc 01 04 09 0c 15 1c 25 28 2d 2f 34 37 3c 43 4c 53 58 5b 60 63 6c 73 78 7b 84 8b 90 93 98 9a 9f 
128:a2 ab ae b3 b6 bb be c3 ca cf d2 d7 da e3 e6 eb f2 f7 fa 03 06 0a 0d 12 15 1a 1d 22 25 2a 31 36 
160:3
544:a9 ae b1 ba c1 c5 c9 cd d1 d5 d8 e1 e4 e9 ec f1 f4 f9 00 05 08 0d 10 19 1c 21 28 2d [876.931040 HC 0x113]
[876.936535 HC 0x103]
[876.943541 HC 0x113]
ERR SOP:
000:- 0 54 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 
032:1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 
064:1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 1 1 2 2 2 1 1 1 1 2 2 
096:2 1 1 1 1 2 2 2 1 1 1 1 1 1 2 2 2 1 1 1 1 2 2 1 1 2 2 1 1 1 1 1 
128:1 2 1 1 1 1 2 1 1 1 1 1 1 2 1 1 2 1 1 2 1 1 1 1 1 1 1 1 1 1 2 1 
160:1 1 1 1 1 2 1 1 1 1 1 1 1 1 1 1 1 1 2 2 1 1 1 1 2 2 1 1 2 2 1 1 
192:1 1 1 1 1 1 2 1 1 2 2 1 1 2 1 1 1 1 1 1 1 1 2 1 1 2 1 1 1 1 2 2 
224:1 1 2 1 1 1 1 2 2 1 1 
000:2a 2a 01 0a 0d 12 19 1d 21 29 2d 31 39 3d 40 49 4c 51 58 5d 60 69 6c 71 78 7d 80 89 8c 91 98 9d 
032:9f a8 ab b0 b7 bc bf c8 cb d0 d7 dc df e8 eb f0 f7 fc ff 08 0a 0f 16 1b 1e 27 2a 2f 36 3b 3e 47 
064:4a 4f 56 5b 5e 67 6a 6f 76 7a 7d 86 89 8e 95 9a 9d a6 a9 ae b5 ba bd c6 cd d6 d9 de e1 e6 ec f5 
096:fc 01 04 09 0c 15 1c 25 28 2d 30 35 38 3d 44 4d 54 58 5b 60 63 6c 73 78 7b 84 8b 90 93 98 9b a0 
128:a3 ac af b4 b7 bc c2 c7 ca cf d2 d7 da e3 e6 eb f2 f7 fa 03 06 0b 0e 13 16 1b 1e 23 26 2b 31 36 
160:3
544:91 96 99 a2 a9 ae b1 ba c1 c5 c9 cd d0 d5 d8 e1 e4 e9 ec f1 f8 fd 00 05 08 0d 10 19 2a 2d 32 39 3d 
...
Shawn, is there an indication that the 87W power source here is doing anything out of spec by sending a SRCCAP so soon after PS_RDY?

Also, since we identify that we have RX errors on our side, is there anything we can do about it to get us back into a sane state? Soft reset or hard reset?
I don't think the source is out of spec by sending source caps so soon after PS_RDY, but it is definitely out of spec by bursting several source caps at period < tTypeCSendSourceCap. Anyway, we made the same mistake before w.r.t. tTypeCSendSourceCap / retries, samus can handle it.

I did notice strong correlation between system load and being able to repro this bug, so I've been experimenting. If I leave ILIM fixed at 500mA (nothing else changed, eg. still negotiate 20V @ 3A) I can't repro this issue anymore. Maybe the CC voltage levels are marginal under load, either from noise on our side or some unknown issue on the charger side. Probably the next step is to break out a scope and probe the CC levels during failed comms.

Sign in to add a comment