New issue
Advanced search Search tips

Issue 784054 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in SkString::Rec::Make

Project Member Reported by ClusterFuzz, Nov 11 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6426932840497152

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ {*}
Crash Address: 0x60f000001c1c
Crash State:
  SkString::Rec::Make
  SkString::SkString
  SkString::set
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=515012:515091

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6426932840497152

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 

Comment 1 by est...@chromium.org, Nov 11 2017

Components: Internals>Skia
Owner: hcm@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by sheriffbot@chromium.org, Nov 11 2017

Labels: M-64
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 11 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 11 2017

Labels: Pri-1
Project Member

Comment 5 by ClusterFuzz, Nov 11 2017

Labels: OS-Linux

Comment 6 by aarya@google.com, Nov 13 2017

Cc: hcm@chromium.org
Owner: ----
Status: Available (was: Assigned)
Letting ClusterFuzz to auto-assign right owner.
Project Member

Comment 7 by ClusterFuzz, Nov 13 2017

Labels: Test-Predator-Auto-Owner
Owner: vmp...@chromium.org
Status: Assigned (was: Available)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/06970f10e5aab4e7b49196a335f9fbca1df5fa16 (Reland "oop: Implement linux oop fonts support.").

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 8 by ClusterFuzz, Nov 13 2017

ClusterFuzz has detected this issue as fixed in range 515858:515862.

Detailed report: https://clusterfuzz.com/testcase?key=6426932840497152

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ {*}
Crash Address: 0x60f000001c1c
Crash State:
  SkString::Rec::Make
  SkString::SkString
  SkString::set
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=515012:515091
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=515858:515862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6426932840497152

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6426932840497152 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 13 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 11 by mmoroz@google.com, Nov 27 2017

Cc: enne@chromium.org
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 19 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment