New issue
Advanced search Search tips

Issue 784052 link

Starred by 1 user
Status: Fixed
Owner:
mek@chromium.org
Closed: Nov 2017
Cc:
dmu...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 611935
issue 776166



Sign in to add a comment

[mojo-blobs] Free |embedded_data| if browser process is going to request data async later.

Project Member Reported by mek@chromium.org, Nov 11 2017 
Currently the mojo code has a bug where even if we're not going to use embedded_data, we're still keeping around the data. That kind of defeats the purpose of requesting the data again later. So I should fix the code to clear out embedded_data for data elements when data will be transferred async later.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/05967cc949440e3735ee0027e17a66ab230aa977

commit 05967cc949440e3735ee0027e17a66ab230aa977
Author: Marijn Kruisselbrink <mek@chromium.org>
Date: Tue Nov 14 03:24:33 2017

Free up blobs embedded_data if the data isn't going to be used.

This should never be more than a few hundred Kb, but it's still cleaner
to throw away this data as soon as we can, otherwise we'd completely
defeat the purpose of not using embedded_data in the first place.

Bug:  784052 
Change-Id: I4b80c63502ddea85ff5942900d832b40167a65c1
Reviewed-on: https://chromium-review.googlesource.com/767449
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516167}
[modify] https://crrev.com/05967cc949440e3735ee0027e17a66ab230aa977/storage/browser/blob/blob_registry_impl.cc

Comment 2 by mek@chromium.org, Nov 14 2017

Status: Fixed (was: Available)
►

Sign in to add a comment