LevelDB database service caches blocks on bulk scans |
||
Issue descriptionThe implementation should use the ReadOptions to not cache blocks when it does block scans. This is because the service is either doing a: 1. Prefix-based delete, so those blocks definitely don't need to be in the cache / kick other blocks out of the cache, and 2. Prefix-based getAll, which 'should' only be called sparingly and cached by the user.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d589808020afc5f0f949d1b82219953ae183340 commit 1d589808020afc5f0f949d1b82219953ae183340 Author: Daniel Murphy <dmurph@chromium.org> Date: Tue Nov 14 00:11:15 2017 [LevelDBService] Disabling block caching on bulk scans Bug: 784020 Change-Id: I973eb7cbd7067ce3a95a4ee4781f9d8aa3d54739 Reviewed-on: https://chromium-review.googlesource.com/765096 Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#516102} [modify] https://crrev.com/1d589808020afc5f0f949d1b82219953ae183340/components/leveldb/leveldb_database_impl.cc
,
Nov 14 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by dmu...@chromium.org
, Nov 11 2017