New issue
Advanced search Search tips

Issue 784013 link

Starred by 1 user
Status: Verified
Owner:
sammiequon@chromium.org
Closed: Dec 2017
Cc:
omrilio@chromium.org
x...@chromium.org
zork@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug


Participants' hotlists:
Fixing-touch


Sign in to add a comment

Regression: Long press on overview button not working properly with splitview.

Project Member Reported by sammiequon@chromium.org, Nov 11 2017 
What steps will reproduce the problem?
(1) Open a couple window and enter tablet mode then overview mode.
(2) Long press overview button to snap left.
(3) Tap overview button to snap right.
(4) Tap overview button to unsnap right.
(5) Long press overview button.

What is the expected result?
Opens snapped left app.

What happens instead?
Opens snapped left app, but you can see remnants of the other apps.

Also, opening overview (no snap) and then long pressing the overview button shows "Cannot snap" toast.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/580adadc1d1325d8ba015bb1841f80dab4128f69

commit 580adadc1d1325d8ba015bb1841f80dab4128f69
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Nov 27 19:15:07 2017

splitview: Fix bugs with long press on overview button.

Fix bug where if one item is snapped, and we long press to exit split
view, some of the overview mode is still visible.
Fix bug where long press no longer opens split view when used in overview
mode. I think this is because wm::ActiveWindow no longer returns nullptr
in overview mode.

Test: ash_unittests SplitViewControllerTest.LongPress*
Bug:  784013 
Change-Id: Ib7cd5f621b7dbd9fc8200aca6656cdb6a7a4d8d2
Reviewed-on: https://chromium-review.googlesource.com/767044
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519358}
[modify] https://crrev.com/580adadc1d1325d8ba015bb1841f80dab4128f69/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/580adadc1d1325d8ba015bb1841f80dab4128f69/ash/wm/splitview/split_view_controller_unittest.cc

Comment 2 by sammiequon@chromium.org, Dec 4 2017

Status: Fixed (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26863ea2799fd936613d77f5fb3d0b69d83a6d8f

commit 26863ea2799fd936613d77f5fb3d0b69d83a6d8f
Author: Sammie Quon <sammiequon@google.com>
Date: Wed Dec 06 19:17:57 2017

splitview: Activate correct window when using longpress to exit split.

Suggestion from oshima@ and xdai@ from
https://chromium-review.googlesource.com/c/chromium/src/+/767044 but
already commited when seen.

Test: ash_unittests SplitViewControllerTest.LongPressExitsSplitView
Bug:  784013 
Change-Id: Ib4123316e78060c4dbab86eb27dd193b8c888d9f
Reviewed-on: https://chromium-review.googlesource.com/798638
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522158}
[modify] https://crrev.com/26863ea2799fd936613d77f5fb3d0b69d83a6d8f/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/26863ea2799fd936613d77f5fb3d0b69d83a6d8f/ash/wm/splitview/split_view_controller_unittest.cc

Comment 4 by sdantul...@chromium.org, Jan 5 2018

Status: Verified (was: Fixed)
10279.0.0, 65.0.3311.0
►

Sign in to add a comment