Kevin, etc.: kernel complains "cros-ec-rtc: wakeup source activated, active_count=3" |
||||
Issue descriptionRajat recently [1] added some debugging info for spurious wake events. I've now been seeing these show up on Kevin (and also Scarlet). e.g., my kevin's been sitting with small periods of activity for a few days, and I see: localhost ~ # dmesg | grep cros-ec-rtc [ 0.755319] cros-ec-rtc cros-ec-rtc: rtc core: registered cros-ec-rtc as rtc0 [ 0.874641] cros-ec-rtc cros-ec-rtc: setting system clock to 2017-11-07 23:41:30 UTC (1510098090) [ 7.850871] cros-ec-rtc: wakeup source activated, active_count=1 [ 8.900249] cros-ec-rtc: wakeup source activated, active_count=2 [86409.024499] cros-ec-rtc: wakeup source activated, active_count=3 [172809.029247] cros-ec-rtc: wakeup source activated, active_count=4 Is that bad? None of those are around suspend/resume attempts, but I guess the RTC gets used for runtime alarms too? If this is WAI, I guess we can just close this WontFix. But I thought I'd ask. [1] https://chromium-review.googlesource.com/724235
,
Nov 11 2017
Thanks. So somewhat WAI? The RTC interface holds the wakesource active (pm_stay_awake() / pm_relax()) only while it's doing some sort of 'work' -- but that "work" can either be handling an RTC IRQ, or when *setting* the RTC time (to be "safe"?). So it's still a little extra spammy, it seems, but I guess that's not a problem.
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/4d3ea038114e72ae905d53be645c3ee28f5ce91e commit 4d3ea038114e72ae905d53be645c3ee28f5ce91e Author: Douglas Anderson <dianders@chromium.org> Date: Thu Jan 11 08:20:52 2018 Revert "CHROMIUM: pm/wakeup: log the wake source when activated" This reverts commit d8a0de8cbb4a716a95775bf06dc71136a1f4fc30. Reason for revert: This is way too much logging. At least looking at rk3399, this logs stuff almost constantly as a user is typing and that's bad. Before re-landing we'd want to enable these logs only during suspend/resume cycles when they're useful. Original change's description: > CHROMIUM: pm/wakeup: log the wake source when activated > > Log a wakeup source that gets activated. This is useful to debug > spurious wakes, suspend failures, and some other difficult to > debug situations. > > Signed-off-by: Rajat Jain <rajatja@google.com> > > BUG=None > TEST=verify wake on wifi is logged > > Change-Id: Ief7e61900dd3be144ded8ed38d48a9cc9ed2bf1d > Reviewed-on: https://chromium-review.googlesource.com/724235 > Commit-Ready: Rajat Jain <rajatja@chromium.org> > Tested-by: Rajat Jain <rajatja@chromium.org> > Reviewed-by: Dmitry Torokhov <dtor@chromium.org> BUG= chromium:798537 , chromium:784000 TEST=Boot and no more spam Change-Id: I48076fae775bd490f3f72ff54a2d0a7b140d22a0 Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/861173 Reviewed-by: Rajat Jain <rajatja@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/4d3ea038114e72ae905d53be645c3ee28f5ce91e/drivers/base/power/wakeup.c
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/6e1618e065fc43c33e6dcbcf764aa5a98ef9411d commit 6e1618e065fc43c33e6dcbcf764aa5a98ef9411d Author: Douglas Anderson <dianders@chromium.org> Date: Thu Jan 11 21:00:16 2018 Revert "CHROMIUM: pm/wakeup: log the wake source when activated" This reverts commit d8a0de8cbb4a716a95775bf06dc71136a1f4fc30. Reason for revert: This is way too much logging. At least looking at rk3399, this logs stuff almost constantly as a user is typing and that's bad. Before re-landing we'd want to enable these logs only during suspend/resume cycles when they're useful. Original change's description: > CHROMIUM: pm/wakeup: log the wake source when activated > > Log a wakeup source that gets activated. This is useful to debug > spurious wakes, suspend failures, and some other difficult to > debug situations. > > Signed-off-by: Rajat Jain <rajatja@google.com> > > BUG=None > TEST=verify wake on wifi is logged > > Change-Id: Ief7e61900dd3be144ded8ed38d48a9cc9ed2bf1d > Reviewed-on: https://chromium-review.googlesource.com/724235 > Commit-Ready: Rajat Jain <rajatja@chromium.org> > Tested-by: Rajat Jain <rajatja@chromium.org> > Reviewed-by: Dmitry Torokhov <dtor@chromium.org> BUG= chromium:798537 , chromium:784000 TEST=Boot and no more spam Change-Id: I48076fae775bd490f3f72ff54a2d0a7b140d22a0 Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/861173 Reviewed-by: Rajat Jain <rajatja@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> (cherry picked from commit 4d3ea038114e72ae905d53be645c3ee28f5ce91e) Reviewed-on: https://chromium-review.googlesource.com/862443 [modify] https://crrev.com/6e1618e065fc43c33e6dcbcf764aa5a98ef9411d/drivers/base/power/wakeup.c |
||||
►
Sign in to add a comment |
||||
Comment 1 by rajatja@google.com
, Nov 10 2017