New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783994 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

When removing a device attributes are not also removed

Project Member Reported by haddowk@chromium.org, Nov 10 2017

Issue description


If you re-add the device ( even if it is a different device ) the existing attributes seem to still apply to that device

https://screenshot.googleplex.com/sBJGwEZKQhT

On removal from autotest, all attributes for that device should be removed also.
 
Components: Infra>Client>ChromeOS
Owner: ----
Owner: mattmallett@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/77545a3bff0ee92466f6158855153fb6d40da21d

commit 77545a3bff0ee92466f6158855153fb6d40da21d
Author: Matt Mallett <mattmallett@chromium.org>
Date: Fri Feb 09 07:42:41 2018

[moblab] Remove orphaned attributes

Remove attributes associated with a DUT when it is deleted.
Also check for and remove attributes on a new DUT, so that
new DUTs aren't picking up orphaned attributes from previously
deleted DUTs.

BUG= chromium:783994 
TEST=local moblab device

Change-Id: If244470c64226bb8c60a1edaf0da092f40261906
Reviewed-on: https://chromium-review.googlesource.com/896581
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[modify] https://crrev.com/77545a3bff0ee92466f6158855153fb6d40da21d/frontend/afe/models.py

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 12 2018

Labels: merge-merged-release-R65-10323.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a54bf71f8adcc944a936e13d88d2a07f63486654

commit a54bf71f8adcc944a936e13d88d2a07f63486654
Author: Matt Mallett <mattmallett@chromium.org>
Date: Mon Feb 12 21:00:27 2018

[moblab] Remove orphaned attributes

Remove attributes associated with a DUT when it is deleted.
Also check for and remove attributes on a new DUT, so that
new DUTs aren't picking up orphaned attributes from previously
deleted DUTs.

BUG= chromium:783994 
TEST=local moblab device

Change-Id: If244470c64226bb8c60a1edaf0da092f40261906
Reviewed-on: https://chromium-review.googlesource.com/896581
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 77545a3bff0ee92466f6158855153fb6d40da21d)
Reviewed-on: https://chromium-review.googlesource.com/912171
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/a54bf71f8adcc944a936e13d88d2a07f63486654/frontend/afe/models.py

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 12 2018

Labels: merge-merged-release-R64-10176.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9bc913f8ad8c5ff7fcc544f4b9deeb4e3de23d87

commit 9bc913f8ad8c5ff7fcc544f4b9deeb4e3de23d87
Author: Matt Mallett <mattmallett@chromium.org>
Date: Mon Feb 12 21:00:33 2018

[moblab] Remove orphaned attributes

Remove attributes associated with a DUT when it is deleted.
Also check for and remove attributes on a new DUT, so that
new DUTs aren't picking up orphaned attributes from previously
deleted DUTs.

BUG= chromium:783994 
TEST=local moblab device

Change-Id: If244470c64226bb8c60a1edaf0da092f40261906
Reviewed-on: https://chromium-review.googlesource.com/896581
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Matt Mallett <mattmallett@chromium.org>
Reviewed-by: Richard Barnette <jrbarnette@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit 77545a3bff0ee92466f6158855153fb6d40da21d)
Reviewed-on: https://chromium-review.googlesource.com/912169
Commit-Queue: Matt Mallett <mattmallett@chromium.org>
Trybot-Ready: Matt Mallett <mattmallett@chromium.org>

[modify] https://crrev.com/9bc913f8ad8c5ff7fcc544f4b9deeb4e3de23d87/frontend/afe/models.py

Status: Fixed (was: Started)

Comment 9 by hadd...@google.com, Jan 18 (4 days ago)

Cc: dshi@chromium.org dchan@chromium.org haddowk@chromium.org
 Issue 537431  has been merged into this issue.

Sign in to add a comment