New issue
Advanced search Search tips

Issue 783990 link

Starred by 1 user
Status: Fixed
Owner:
juncai@chromium.org
Closed: May 2018
Cc:
est...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-Servicification

Blocking:
issue 756654



Sign in to add a comment

Add http auth support for network service

Project Member Reported by jam@chromium.org, Nov 10 2017 
content/network's URLLoader needs to implement OnAuthRequired. Luckily that interface is already asynchronous. It'll have to IPC to the browser and go through the same code path that ResourceLoader::OnAuthRequired currently does. As an example, see r513989 which did this for OnSSLCertificateError.

This should fix the following content_browsertests:
WorkerFetchTest.SharedWorkerHttpAuth/0
WorkerFetchTest.SharedWorkerHttpAuth/1
WorkerFetchTest.WorkerHttpAuth/1
WorkerFetchTest.WorkerHttpAuth/0

and browser_tests:
LoginPromptBrowserTest.AllowCrossdomainPromptForSubframes
LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources
LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect
LoginPromptBrowserTest.CancelRedundantAuths
LoginPromptBrowserTest.IncorrectConfirmation
LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentials
LoginPromptBrowserTest.LoginPromptForXHRWithoutCredentialsCancelled
LoginPromptBrowserTest.MultipleRealmCancellation
LoginPromptBrowserTest.MultipleRealmConfirmation
LoginPromptBrowserTest.NoLoginPromptForFavicon
LoginPromptBrowserTest.ShouldNotProceedExistingInterstitial
LoginPromptBrowserTest.ShouldReplaceExistingInterstitialWhenNavigated
LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRedirects
LoginPromptBrowserTest.ShowCorrectUrlForCrossOriginMainFrameRequests
LoginPromptBrowserTest.SupplyRedundantAuths
LoginPromptBrowserTest.SupplyRedundantAuthsMultiProfile
LoginPromptBrowserTest.TestBasicAuth
LoginPromptBrowserTest.TestCancelAuth_Manual
LoginPromptBrowserTest.TestCancelAuth_OnBack
LoginPromptBrowserTest.TestCancelAuth_OnForward
LoginPromptBrowserTest.TestCancelAuth_OnNavigation
LoginPromptBrowserTest.TestDigestAuth
LoginPromptBrowserTest.TestTwoAuths
PasswordManagerBrowserTestBase.BasicAuthSeparateRealms
PasswordManagerBrowserTestBase.CorrectEntryForHttpAuth
PasswordManagerBrowserTestBase.NoLastLoadGoodLastLoad
PrerenderBrowserTest.PrerenderHttpAuthentication
ProxyBrowserTest.BasicAuthWSConnect
RepostFormWarningTest.TestLoginAfterRepost
WebSocketBrowserTest.ReuseMainPageBasicAuthCredentialsForWebSocket

Comment 1 by juncai@chromium.org, Dec 5 2017

Owner: juncai@chromium.org
Status: Assigned (was: Available)

Comment 2 by juncai@chromium.org, Dec 8 2017

Status: Started (was: Assigned)

Comment 3 by juncai@chromium.org, Feb 7 2018

Blocking: 809819
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cfb0cf01a70b32274ece79b4206501f9c74738e

commit 2cfb0cf01a70b32274ece79b4206501f9c74738e
Author: Jun Cai <juncai@chromium.org>
Date: Tue Feb 27 01:28:09 2018

NetworkService: Implement URLLoader::OnAuthRequired

The design doc is at:
https://docs.google.com/document/d/1x8rpRMWUEOg70461gicuf8tkbESPMsnUNyJS_6wUnYk/edit

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: If19008ec892937bab4c237e7c1419e48555393ee
Reviewed-on: https://chromium-review.googlesource.com/877512
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539362}
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/aw_login_delegate.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/aw_login_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/chrome/browser/ui/views/login_handler_views.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/cross_site_resource_handler_browsertest.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/network_service_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/network_service_client.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/public/browser/content_browser_client.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/public/browser/resource_dispatcher_host.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/BUILD.gn
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/layout_test/layout_test_content_browser_client.h
[delete] https://crrev.com/f5f9fe791ff1d5985bcad10b4cabbbdbf7c6225c/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.cc
[delete] https://crrev.com/f5f9fe791ff1d5985bcad10b4cabbbdbf7c6225c/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/shell_login_dialog.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/content/shell/browser/shell_login_dialog.h
[delete] https://crrev.com/f5f9fe791ff1d5985bcad10b4cabbbdbf7c6225c/content/shell/browser/shell_resource_dispatcher_host_delegate.cc
[delete] https://crrev.com/f5f9fe791ff1d5985bcad10b4cabbbdbf7c6225c/content/shell/browser/shell_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/url_loader.cc
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/services/network/url_loader.h
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/2cfb0cf01a70b32274ece79b4206501f9c74738e/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26753e6dc4b017b8cc296a1128d8dbe7ac580770

commit 26753e6dc4b017b8cc296a1128d8dbe7ac580770
Author: Jun Cai <juncai@chromium.org>
Date: Tue Feb 27 02:06:23 2018

Revert "NetworkService: Implement URLLoader::OnAuthRequired"

This reverts commit 2cfb0cf01a70b32274ece79b4206501f9c74738e.

Reason for revert:
Based on the comment at:
https://chromium-review.googlesource.com/c/chromium/src/+/877512/19
Empty credentials are valid, so need to update code not to use empty credentials as indication to call URLRequest::CancelAuth().

Original change's description:
> NetworkService: Implement URLLoader::OnAuthRequired
> 
> The design doc is at:
> https://docs.google.com/document/d/1x8rpRMWUEOg70461gicuf8tkbESPMsnUNyJS_6wUnYk/edit
> 
> Bug:  783990 
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
> Change-Id: If19008ec892937bab4c237e7c1419e48555393ee
> Reviewed-on: https://chromium-review.googlesource.com/877512
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Commit-Queue: Jun Cai <juncai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539362}

TBR=jam@chromium.org,mmenke@chromium.org,tsepez@chromium.org,juncai@chromium.org,asanka@chromium.org

Change-Id: I650635d655ed78f7d74d0cfb3a1ac00703430da8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Reviewed-on: https://chromium-review.googlesource.com/938902
Reviewed-by: Jun Cai <juncai@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539372}
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/aw_login_delegate.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/aw_login_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/chrome/browser/ui/views/login_handler_views.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/cross_site_resource_handler_browsertest.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/network_service_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/network_service_client.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/public/browser/content_browser_client.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/public/browser/resource_dispatcher_host.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/BUILD.gn
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/layout_test/layout_test_content_browser_client.h
[add] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.cc
[add] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_login_dialog.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_login_dialog.h
[add] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_resource_dispatcher_host_delegate.cc
[add] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/content/shell/browser/shell_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/url_loader.cc
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/services/network/url_loader.h
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/26753e6dc4b017b8cc296a1128d8dbe7ac580770/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 28 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc561f417634ce7326816b5167476003386e947b

commit bc561f417634ce7326816b5167476003386e947b
Author: Jun Cai <juncai@chromium.org>
Date: Wed Feb 28 18:41:39 2018

Reland of NetworkService: Implement URLLoader::OnAuthRequired

The initial upload patch of this CL is the same as:
https://chromium-review.googlesource.com/c/chromium/src/+/877512

This reland CL addresses comments at:
https://chromium-review.googlesource.com/c/chromium/src/+/877512/19

The initial upload patch of this CL uses empty credential to indicate
that URLRequest::CancelAuth() needs to be called, which is incorrect
because empty credentials are valid. The latest patch of this CL
contains the fix for this issue.

TBR=jam@chromium.org, tsepez@chromium.org

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifdbab56badaf3e13b5f15f5aa0d31cfb764325c6
Reviewed-on: https://chromium-review.googlesource.com/938960
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Reviewed-by: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539903}
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/aw_login_delegate.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/aw_login_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/android/login_handler_android.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/cocoa/login_handler_cocoa.mm
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/views/browser_dialogs_views.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/chrome/browser/ui/views/login_handler_views.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/cross_site_transfer_browsertest.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/cross_site_resource_handler_browsertest.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/loader/resource_request_info_impl.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/network_service_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/network_service_client.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/browser/web_contents/web_contents_impl_browsertest.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/public/browser/content_browser_client.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/public/browser/resource_dispatcher_host.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/public/browser/resource_dispatcher_host_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/BUILD.gn
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/layout_test/layout_test_content_browser_client.h
[delete] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.cc
[delete] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/content/shell/browser/layout_test/layout_test_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/shell_login_dialog.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/content/shell/browser/shell_login_dialog.h
[delete] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/content/shell/browser/shell_resource_dispatcher_host_delegate.cc
[delete] https://crrev.com/ead4271f098dd2038ec8514f1bf9b59f83b0774b/content/shell/browser/shell_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/public/cpp/network_param.typemap
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/public/cpp/network_param_ipc_traits.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/public/cpp/network_param_ipc_traits.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/url_loader.cc
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/services/network/url_loader.h
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[modify] https://crrev.com/bc561f417634ce7326816b5167476003386e947b/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter

Comment 7 by juncai@chromium.org, Mar 2 2018

Blocking: -809819
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5628ada2a07b4f9afae3fddb7cedff26cc507ef

commit a5628ada2a07b4f9afae3fddb7cedff26cc507ef
Author: Jun Cai <juncai@chromium.org>
Date: Fri Mar 02 21:58:24 2018

NetworkService: Make ResourceDispatcherHostImpl::RunAuthRequiredCallback() bind to request ID

This is a follow-up CL that addresses the comment at:
https://chromium-review.googlesource.com/c/chromium/src/+/938960/4/content/browser/loader/resource_dispatcher_host_impl.cc#2615

By making ResourceDispatcherHostImpl::RunAuthRequiredCallback() bind to
request ID, we can safely verify the loader and the request are still
valid before calling CancelAuth()/SetAuth().

Bug:  783990 
Change-Id: Id45b16d08b2dbde3df4c1e2a13f0e780fcef68dd
Reviewed-on: https://chromium-review.googlesource.com/942229
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540647}
[modify] https://crrev.com/a5628ada2a07b4f9afae3fddb7cedff26cc507ef/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/a5628ada2a07b4f9afae3fddb7cedff26cc507ef/content/browser/loader/resource_dispatcher_host_impl.h
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7502e51c35ca726b70bd63358575c8e7829efbc

commit d7502e51c35ca726b70bd63358575c8e7829efbc
Author: Jun Cai <juncai@chromium.org>
Date: Fri Mar 02 23:49:07 2018

NetworkService: Rename ResourceDispatcherHostLoginDelegate to LoginDelegate

This CL renames ResourceDispatcherHostLoginDelegate to
LoginDelegate since it is not only used for ResourceDispatcherHost.

Bug:  809819 ,  783990 
Change-Id: If07153ffa903c754f0ea5198745a560b266829ad
Reviewed-on: https://chromium-review.googlesource.com/907319
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540684}
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/android_webview/browser/aw_login_delegate.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader_delegate.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/loader/resource_loader_unittest.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/browser/network_service_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/BUILD.gn
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/content_browser_client.h
[rename] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/public/browser/login_delegate.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/layout_test/layout_test_content_browser_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/layout_test/layout_test_content_browser_client.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_content_browser_client.cc
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_content_browser_client.h
[modify] https://crrev.com/d7502e51c35ca726b70bd63358575c8e7829efbc/content/shell/browser/shell_login_dialog.h
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 23 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85ccead28b4924f228bc8c11823ce3418a640b41

commit 85ccead28b4924f228bc8c11823ce3418a640b41
Author: Jun Cai <juncai@chromium.org>
Date: Mon Apr 23 20:28:25 2018

Network Service: Remove WorkerTest.SharedWorkerHttpAuth

As discussed at:
https://groups.google.com/a/chromium.org/forum/#!topic/network-service-dev/GWJCro1UnKw
The WorkerTest.SharedWorkerHttpAuth doesn't test what it means to test,
and what it means to test doesn't work with or without network service,
so this CL removes this test.

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I8fa60dbd145926bfc3955fd9060c4105a733cf1c
Reviewed-on: https://chromium-review.googlesource.com/1024485
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552814}
[modify] https://crrev.com/85ccead28b4924f228bc8c11823ce3418a640b41/content/browser/shared_worker/worker_browsertest.cc
[modify] https://crrev.com/85ccead28b4924f228bc8c11823ce3418a640b41/testing/buildbot/filters/mojo.fyi.network_content_browsertests.filter
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 24 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ace6726bd778c8e651be97204347c228d3f7142e

commit ace6726bd778c8e651be97204347c228d3f7142e
Author: Jun Cai <juncai@chromium.org>
Date: Tue Apr 24 23:44:12 2018

Network Service: Fix some LoginPromptBrowserTest related to cancelling auth request

This CL fixes some LoginPromptBrowserTest related to cancelling auth
request, in this case, LoginHandler::OnRequestCancelled() needs to be
called.

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Id87ce38aec5191e40b3b282b4cde0304ea769d92
Reviewed-on: https://chromium-review.googlesource.com/1008846
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553369}
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/content/browser/network_service_client.cc
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/content/browser/network_service_client.h
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/services/network/url_loader.cc
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/services/network/url_loader.h
[modify] https://crrev.com/ace6726bd778c8e651be97204347c228d3f7142e/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 27 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1

commit d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1
Author: Jun Cai <juncai@chromium.org>
Date: Fri Apr 27 00:50:20 2018

Network Service: Fix LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources

This CL fixes LoginPromptBrowserTest.BlockCrossdomainPromptForSubresources
by reusing the same logic at ResourceDispatcherHostImpl which prevents
third-party image content from prompting for login.

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ifce3963813134e164bf266fb5f4bb895f5018bd5
Reviewed-on: https://chromium-review.googlesource.com/1029217
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554235}
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/content/browser/loader/resource_dispatcher_host_impl.h
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/content/browser/network_service_client.cc
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/content/browser/network_service_client.h
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/services/network/public/mojom/network_service.mojom
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/services/network/url_loader.cc
[modify] https://crrev.com/d7cd4e71aca7835b5fee3be5cb68503fe6bd6ed1/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
Project Member

Comment 13 by bugdroid1@chromium.org, May 1 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5b5f561a2250c70b267f1c74c0f826c1413b1e

commit 9d5b5f561a2250c70b267f1c74c0f826c1413b1e
Author: Jun Cai <juncai@chromium.org>
Date: Tue May 01 21:46:15 2018

Network Service: Add auth unit tests for URLLoader

This CL adds auth unit tests for URLLoader.

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I3d0d9ee4c43ba4bb21459d0a6bdf35fef9cca946
Reviewed-on: https://chromium-review.googlesource.com/1028711
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555189}
[modify] https://crrev.com/9d5b5f561a2250c70b267f1c74c0f826c1413b1e/services/network/url_loader_unittest.cc
Project Member

Comment 14 by bugdroid1@chromium.org, May 3 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d628465e254b91bc14f84d59d2999d6148df3d7

commit 1d628465e254b91bc14f84d59d2999d6148df3d7
Author: Jun Cai <juncai@chromium.org>
Date: Thu May 03 02:31:32 2018

Network Service: Fix some LoginPromptBrowserTest by adding |do_not_prompt_for_login_| flag for URLLoader

This CL fixes some LoginPromptBrowserTest by adding a
|do_not_prompt_for_login_| flag for URLLoader. It is similar to what
ResourceLoader::OnAuthRequired() does.

Bug:  783990 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I86d72fcf64429a3d78231ce55fc1bb07359c7caa
Reviewed-on: https://chromium-review.googlesource.com/1015742
Commit-Queue: Jun Cai <juncai@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#555653}
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/content/renderer/loader/web_url_loader_impl.cc
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/services/network/url_loader.cc
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/services/network/url_loader.h
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/services/network/url_loader_unittest.cc
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/services/test/BUILD.gn
[add] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/services/test/data/has_favicon.html
[modify] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
[add] https://crrev.com/1d628465e254b91bc14f84d59d2999d6148df3d7/third_party/WebKit/LayoutTests/flag-specific/enable-features=NetworkService/http/tests/inspector-protocol/network/xhr-interception-auth-fail-expected.txt

Comment 15 by juncai@chromium.org, May 3 2018

Status: Fixed (was: Started)
Project Member

Comment 16 by bugdroid1@chromium.org, May 14 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e165d23e87e33802b60c68006c3fed5a3ca7bf4

commit 8e165d23e87e33802b60c68006c3fed5a3ca7bf4
Author: Jun Cai <juncai@chromium.org>
Date: Mon May 14 19:21:24 2018

Network Service: Change |is_main_frame| variable name to |is_request_for_main_frame|

Based on the discussion at:
https://chromium-review.googlesource.com/c/chromium/src/+/1050935/5/content/browser/network_service_client.cc
This CL changes the |is_main_frame| variable name to |is_request_for_main_frame|
to make it more clear. The variable indicates if the request (associated
with a frame) is the request for the frame itself or a subresource.

Bug:  783990 
Change-Id: I0369efc027c27cac3c19a1ce48a0fba7a67809a0
Reviewed-on: https://chromium-review.googlesource.com/1056292
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558411}
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/chrome/browser/chrome_content_browser_client.h
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/chrome/browser/ui/login/login_handler.cc
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/chrome/browser/ui/login/login_handler.h
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/content/browser/network_service_client.cc
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/content/public/browser/content_browser_client.cc
[modify] https://crrev.com/8e165d23e87e33802b60c68006c3fed5a3ca7bf4/content/public/browser/content_browser_client.h
►

Sign in to add a comment