New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783978 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

'Contact support' button on Eve should direct to the phone number section when offline

Project Member Reported by wzang@chromium.org, Nov 10 2017

Issue description

Chrome Version: 64.0.3264.0
OS: Chrome

What steps will reproduce the problem?
(1) Open Get help app on Eve.
(2) Disconnect the Internet.
(3) Click 'Contact support' button.

What is the expected result?
It should redirect to the phone number section.

What happens instead?
It redirects to the first section, which is 'Set up your Pixelbook', whereas the phone number section is the 4th section.

This is a regression. The code assumes that the phone number section is the first section in the list, but the 'Set up your Pixelbook' section was added later.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 by wzang@chromium.org, Nov 13 2017

Hi Weifang, I've submitted a fix for this. Do you think it's necessary to request merge to M63?
Yes - This is an important support avenue for Eve so we should request a merge to M63. Thanks!!

Comment 3 by wzang@chromium.org, Nov 13 2017

I will verify on device first and request merge. Thanks!
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/1718bdb01b426165df0b735ce5ab82941f93c97d

commit 1718bdb01b426165df0b735ce5ab82941f93c97d
Author: Wenzhao Zang <wzang@chromium.org>
Date: Sat Nov 18 04:18:51 2017

Comment 5 by wzang@chromium.org, Nov 20 2017

Cc: gkihumba@chromium.org
Labels: Merge-Request-63
Verified to work on the latest Canary. Although this is late in the cycle, this change only affects a corner case on Eve only, and we believe it's worth the merge. Thanks!
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 20 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 7 by gkihumba@google.com, Nov 22 2017

Labels: -Merge-Review-63 Merge-Approved-63
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 22 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/chromeos-assets/+/897995ab6545efc998fcc22b3ce16c0612fcdc6c

commit 897995ab6545efc998fcc22b3ce16c0612fcdc6c
Author: Wenzhao Zang <wzang@chromium.org>
Date: Wed Nov 22 23:07:09 2017

Comment 9 by wzang@chromium.org, Nov 22 2017

Labels: -Merge-Approved-63

Comment 10 by wzang@chromium.org, Nov 22 2017

Status: Fixed (was: Assigned)

Sign in to add a comment