Add integration tests for client-side phishing detection |
||||||
Issue descriptionIn https://chromium-review.googlesource.com/c/chromium/src/+/763874 I got rid of one of the two usages of WebContentsObserver::DidGetResourceResponseStart. The remaining one is in ClientSideDetectionHost. Before trying to convert that code, I ran a trybot with making the method empty to see which tests depend on it. The trybots were green though. See https://chromium-review.googlesource.com/c/chromium/src/+/763748 Nathan: can you please take care of this or reassign to someone on your team? If we can even have just one test to exercise this in the next few weeks that'd be great, thanks.
,
Nov 10 2017
I'll work on this next week.
,
Nov 10 2017
,
Nov 10 2017
,
Nov 13 2017
Thank you!
,
Nov 13 2017
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/896333d6d4dd7fff0852ebb979b7912c82d8e790 commit 896333d6d4dd7fff0852ebb979b7912c82d8e790 Author: Jialiu Lin <jialiul@chromium.org> Date: Mon Nov 20 19:12:08 2017 Add browser test to verify IP collection in client-side detection Bug: 783977 Change-Id: Ib9977a73f9f8021bf9204cd594a9e40fd8d03341 Reviewed-on: https://chromium-review.googlesource.com/777553 Commit-Queue: Jialiu Lin <jialiul@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#517884} [modify] https://crrev.com/896333d6d4dd7fff0852ebb979b7912c82d8e790/chrome/browser/safe_browsing/client_side_detection_host.h [add] https://crrev.com/896333d6d4dd7fff0852ebb979b7912c82d8e790/chrome/browser/safe_browsing/client_side_detection_host_browsertest.cc [modify] https://crrev.com/896333d6d4dd7fff0852ebb979b7912c82d8e790/chrome/test/BUILD.gn
,
Nov 20 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jam@chromium.org
, Nov 10 2017