New issue
Advanced search Search tips

Issue 783969 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Update PlatformSensorAndProviderTest.java to test sensors with 3 or more values

Project Member Reported by juncai@chromium.org, Nov 10 2017

Issue description

This is from the comment in the following CL:
https://chromium-review.googlesource.com/c/chromium/src/+/667784/5

Currently PlatformSensorAndProviderTest.java only tests the LIGHT sensor which only has one value. Adding tests to cover sensors with 3 or more values would be better.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7e6175911c0ff6b18ab48a13cd2998141a7b633

commit a7e6175911c0ff6b18ab48a13cd2998141a7b633
Author: Jun Cai <juncai@chromium.org>
Date: Fri Jan 05 22:37:44 2018

Update PlatformSensorAndProviderTest.java to test sensors with 3 or more values

Currently PlatformSensorAndProviderTest.java tests that shared buffer is
correctly populated from SensorEvent using the LIGHT sensor which only
has one value. This CL adds tests to cover sensors with more values.

Bug:  783969 
Change-Id: Icf21001e7c321518988d4239a5812bf007c762f6
Reviewed-on: https://chromium-review.googlesource.com/852816
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Jun Cai <juncai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527409}
[modify] https://crrev.com/a7e6175911c0ff6b18ab48a13cd2998141a7b633/services/device/generic_sensor/android/junit/src/org/chromium/device/sensors/PlatformSensorAndProviderTest.java

Status: Fixed (was: Started)

Sign in to add a comment