New issue
Advanced search Search tips

Issue 783967 link

Starred by 1 user
Status: Fixed
Owner:
katie@chromium.org
Closed: Nov 2017
Cc:
lpalmaro@chromium.org
dmazz...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

[Select-to-Speak] Can't grab partial line if text wraps

Project Member Reported by katie@chromium.org, Nov 10 2017 
For example:
<html>
  <body>
    <p style="width:250px">
      <i>Italic text</i>
      This is some text in a paragraph that wraps.
      <i>More italics</i>
    </p>
  </body>
</html>

If the user tries to just select one of the italicized sections to read with STS, the non-italicized section is also selected and read aloud.

Possible solution:
select_to_speak.js function findAllMatching_ needs to be more picky about not matching entire parent nodes if they have children who match.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2a76ed0cf5c2e09176629f56a044050d87a6ef8

commit b2a76ed0cf5c2e09176629f56a044050d87a6ef8
Author: Katie Dektar <katydek@google.com>
Date: Wed Nov 15 21:09:09 2017

Select-to-speak can grab partial line if text wraps.

If a node has inlineTextBox children, use those children instead of the
node when looking for matches.

Refactors findAllChildren to make it testable, adds tests.

Bug:  783967 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2617dff01c48fff0e112576d9034e6c87eea2fb0
Reviewed-on: https://chromium-review.googlesource.com/767022
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516827}
[modify] https://crrev.com/b2a76ed0cf5c2e09176629f56a044050d87a6ef8/chrome/browser/resources/chromeos/select_to_speak/select_to_speak.js
[modify] https://crrev.com/b2a76ed0cf5c2e09176629f56a044050d87a6ef8/chrome/browser/resources/chromeos/select_to_speak/select_to_speak_unittest.gtestjs

Comment 2 by katie@chromium.org, Nov 15 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment