Chrome display messed up. |
|||||
Issue descriptionWith the latest chrome canary, the tabstrip / area around the omnibox are being displayed incorrectly. Suspect the issue was caused by one of the CLs in issue 766736 . Current ICM profile is attached.
,
Nov 10 2017
,
Nov 11 2017
Thanks -- I can reproduce this locally.
,
Nov 11 2017
This seems to only affect some color profiles. Odd.
,
Nov 13 2017
I'm seeing the same issue as I reported in https://crbug.com/780848 &desc=2#c1. Themed rendering is particularly afflicted as reported in that comment.
,
Nov 13 2017
Still digging in to this.
,
Nov 14 2017
My canary is essentially useless, as the tabstrip and titlebar are a blank slate. Can we revert until the fix is in?
,
Nov 14 2017
I agree with that - I'm not using Canary at all on affected PCs as a result of this breakage.
,
Nov 14 2017
I have a fix out for review.
,
Nov 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0ed1b15eb13c53aaef98a2647329d7c416879376 commit 0ed1b15eb13c53aaef98a2647329d7c416879376 Author: Christopher Cameron <ccameron@chromium.org> Date: Tue Nov 14 21:58:41 2017 Only use purely parametric SkColorSpaces This fixes a bug where a ColorSpace would continue to use the SkColorSpace that came from the ICCProfile inappropriatley. Inappropriately in this case means that we parametrically approximated the SkColorSpace, but the SkColorSpace itself was not parametric. TBR=hubbe Bug: 783966 Change-Id: Id79b37386b5e6b289b587c0f0ba7418fb5482226 Reviewed-on: https://chromium-review.googlesource.com/769587 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by: Fredrik Hubinette <hubbe@chromium.org> Reviewed-by: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#516445} [modify] https://crrev.com/0ed1b15eb13c53aaef98a2647329d7c416879376/ui/gfx/color_space.cc [modify] https://crrev.com/0ed1b15eb13c53aaef98a2647329d7c416879376/ui/gfx/icc_profile.cc
,
Nov 15 2017
Tested the issue on Windows 10 using Chrome version M64 - 64.0.3269.0 as per the issue mentioned in original comment. Observed that issue is working as intended (Elements displayed across the browser are displayed properly). Hence adding TE-Verified label. Attached the screenshot for reference. Thank you!
,
Nov 17 2017
ccameron@, please mark it as 'Fixed' if there is no other pending CL exists. Thanks..!
,
Nov 17 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mmenke@chromium.org
, Nov 10 2017