New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783965 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Nov 2017
Cc:
█ allada@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: trying to select link in console should not open the link

Project Member Reported by l...@chromium.org, Nov 10 2017 
What steps will reproduce the problem?
(1) Log some linkified text in console, e.g. console.log('www.chromium.org')
(2) Try to select the link text

What is the expected result?
Link text is selected

What happens instead?
Link is opened in a new tab
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1bacfb39730264586bacd2c2840911efb46c883

commit e1bacfb39730264586bacd2c2840911efb46c883
Author: Erik Luo <luoe@chromium.org>
Date: Tue Nov 14 01:35:34 2017

DevTools: do not act on link click if there is selection

Selecting text that includes a link can unexpectedly open the link in
a new tab. This CL only allows link actions when the link has no
selection.

Bug:  783965 
Change-Id: I790f85211a80809fdfce94cfce8ddecde2d0d5be
Reviewed-on: https://chromium-review.googlesource.com/764376
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516137}
[modify] https://crrev.com/e1bacfb39730264586bacd2c2840911efb46c883/third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Comment 2 by l...@chromium.org, Nov 14 2017

Cc: allada@chromium.org
Status: Fixed (was: Assigned)
Thanks for the report allada@!
►

Sign in to add a comment