New issue
Advanced search Search tips

Issue 783963 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

New Window desktop action is duplicated in GNOME Shell

Reported by dylanmcc...@gmail.com, Nov 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Steps to reproduce the problem:
Using GNOME Shell, right click the Google Chrome launcher and read the options.

What is the expected behavior?
The "New Window" action should be listed exactly once.

What went wrong?
Instead, the menu lists "New Window" twice. One is the shell's built in New Window action, and the second is the one defined in Chrome's launcher.

Did this work before? No 

Chrome version: 62.0.3202.89  Channel: stable
OS Version: Fedora Workstation 27
Flash Version: 

This is easily solved: in Google Chrome's desktop entry file (google-chrome.desktop), `Desktop Action NewWindow` should be changed to `Desktop Action new-window`. That is the common name for the new window action.
 
Here is a screenshot showing the problem.
Screenshot from 2017-11-10 14-21-43.png
35.8 KB View Download
Cc: thomasanderson@chromium.org
Labels: Needs-Triage-M62
Owner: thomasanderson@chromium.org
Status: Started (was: Unconfirmed)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eea3abf9add679bf32608f6106b6d108f9e52ec

commit 4eea3abf9add679bf32608f6106b6d108f9e52ec
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Tue Nov 14 00:11:07 2017

Use standard new-window and new-private-window action names in desktop file

When Chrome uses the non-standard NewWindow action, there is a
duplicated entry in GNOME shell: one is the shell's built-in new
window action, and the other is Chrome's.

Using new-window instead solves this issue.

Also, change NewPrivateWindow to use new-private-window as well, since
this is what firefox does.

BUG= 783963 
R=thestig@chromium.org

Change-Id: I9747a402358089bfa297cf32f29c50c2a1f53035
Reviewed-on: https://chromium-review.googlesource.com/764557
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516101}
[modify] https://crrev.com/4eea3abf9add679bf32608f6106b6d108f9e52ec/chrome/installer/linux/common/desktop.template

Status: Fixed (was: Started)
Labels: TE-NeedsTriageFromMTV
We are facing the problems to installing the GNOME Shell, hence adding the respective label for it to verify the issue.

@MTVTeam-- Requesting someone from MTV team please look into this issue.

Thank you!
Status: Verified (was: Fixed)
I run GNOME shell and it's fixed for me.

Sign in to add a comment