[Chrome Home] Allow showing the Chrome Home promo on startup to be disabled |
|||||||||
Issue descriptionWe would like the ability to disable the promo from showing on cold-start for users. This should be controlled by finch.
,
Nov 13 2017
,
Nov 13 2017
Do we want to merge this to M63?
,
Nov 13 2017
Based on how we plan to use this, I imagine we would. But if the larger rollout is happening in 64 it can probably wait. I'll add the tag, we can cancel if we decide we don't need it.
,
Nov 13 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15 2017
Hey what's the update here? Please remove merge label if not needed anymore.
,
Nov 16 2017
I am rejecting the merge since this is not critical and surely late to be merged at this point.
,
Nov 16 2017
Sorry for the delay. I was just about to reply. This may prove critical to an earlier feedback cycle for Chrome Home since we decided not to move forward with the startup promo launch of Chrome Home. Can we allow merge to allow for us to move forward the new launch plan?
,
Nov 16 2017
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 17 2017
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a25b7a7af5e0da04d83388cab60bce2395546e34 commit a25b7a7af5e0da04d83388cab60bce2395546e34 Author: Matthew Jones <mdjones@chromium.org> Date: Fri Nov 17 21:11:48 2017 [Home] Allow the Chrome Home promo to be disabled on startup with finch Since showing the promo at startup is the current behavior, this feature is enabled by default. The feature to disable is "ChromeHomePromoOnStartup". BUG= 783936 Change-Id: I827f7a828a484603860e3ce8362e91b50a6d742a Reviewed-on: https://chromium-review.googlesource.com/764788 Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515798}(cherry picked from commit 862d24329cf7d5365aca1976ebd179b5a0cd1bba) Reviewed-on: https://chromium-review.googlesource.com/777799 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#531} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/a25b7a7af5e0da04d83388cab60bce2395546e34/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java [modify] https://crrev.com/a25b7a7af5e0da04d83388cab60bce2395546e34/chrome/android/java/src/org/chromium/chrome/browser/util/FeatureUtilities.java [modify] https://crrev.com/a25b7a7af5e0da04d83388cab60bce2395546e34/chrome/browser/android/chrome_feature_list.cc [modify] https://crrev.com/a25b7a7af5e0da04d83388cab60bce2395546e34/chrome/browser/android/chrome_feature_list.h |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 11 2017