New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 783932 link

Starred by 1 user
Status: Fixed
Owner:
█ donnd@chromium.org
(OOO slow)
Closed: Nov 2017
Cc:
twelling...@chromium.org
tedc...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Default-disable Smart Selection in Chrome

Project Member Reported by donnd@google.com, Nov 10 2017 
Smart Selection is currently default-enabled, but it should be default-disabled so that enabling of it is gated by the normal Launch Review process.

Background: It's unclear whether the Android-Oreo Smart Text Selection feature will be supported in Chrome starting in M-63 or M-64.  The required support code is all in, with the optional logging code from WebView scheduled for M-64.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3222a271b4acd39847a04eafe41f9ee3b874265

commit f3222a271b4acd39847a04eafe41f9ee3b874265
Author: Donn Denman <donnd@google.com>
Date: Tue Nov 14 21:13:07 2017

Default-disable Smart Selection in Chrome.

Switches the default for Smart Selection in Chrome for Android.
Replaces the CS disable param with an enable Feature.

Update the fieldtrial_testing_config to enable the Feature.

BUG= 783932 , 756241

Change-Id: I4853943871f320c306fed99ec2d4883af7551ae3
Reviewed-on: https://chromium-review.googlesource.com/706644
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516426}
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/SelectionClientManager.java
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/f3222a271b4acd39847a04eafe41f9ee3b874265/testing/variations/fieldtrial_testing_config.json

Comment 2 by donnd@google.com, Nov 15 2017

Cc: tedc...@chromium.org
Labels: Merge-Request-63
Requesting a merge to M-63 to update the way Smart Selection is controlled by Finch to be default disabled and feature-based instead of param-based.  Although this change is not strictly needed for M-63 it will make enabling clear and less error-prone.  This is a very safe fix to merge because it just changes the finch-control mechanism.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 15 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by cma...@chromium.org, Nov 15 2017

Labels: -Hotlist-Merge-Review -Merge-Review-63 Merge-Approved-63
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 16 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7

commit 4ae9b42f9057a4d421d571da7ec6cc09b2b598e7
Author: Donn Denman <donnd@google.com>
Date: Thu Nov 16 01:45:53 2017

Default-disable Smart Selection in Chrome.

Switches the default for Smart Selection in Chrome for Android.
Replaces the CS disable param with an enable Feature.

Update the fieldtrial_testing_config to enable the Feature.

BUG= 783932 , 756241
TBR=donnd@google.com

(cherry picked from commit f3222a271b4acd39847a04eafe41f9ee3b874265)

Change-Id: I4853943871f320c306fed99ec2d4883af7551ae3
Reviewed-on: https://chromium-review.googlesource.com/706644
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#516426}
Reviewed-on: https://chromium-review.googlesource.com/773634
Reviewed-by: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#517}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFieldTrial.java
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/SelectionClientManager.java
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/chrome/browser/android/chrome_feature_list.h
[modify] https://crrev.com/4ae9b42f9057a4d421d571da7ec6cc09b2b598e7/testing/variations/fieldtrial_testing_config.json

Comment 6 by donnd@google.com, Nov 16 2017

Status: Fixed (was: Started)
►

Sign in to add a comment