New issue
Advanced search Search tips

Issue 783917 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Track previews navigation data

Project Member Reported by ryansturm@chromium.org, Nov 10 2017

Issue description

Currently, we track if a preview was eligible or a preview was triggered in a multitude of ways, and we repeat certain bits of logic in vastly different parts of the code. Ideally, we would be able to look up and store key information about a page load and navigation throughout the course of the page load.

This could be tracked in main frame URLRequest's user data and copied to ChromeNavigationData to be tracked in a web contents observer. We would treat the user data as static and finalized after the main frame headers are received and the navigation preview types are determined.

Additionally, each navigation should have an identifier that can be used to track various events about the navigation and consolidate them on chrome://interventions-internals.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/91cd6ea5f5e7da627e19db952a8f4a576cbc422f

commit 91cd6ea5f5e7da627e19db952a8f4a576cbc422f
Author: Ryan Sturm <ryansturm@chromium.org>
Date: Sat Nov 11 02:01:49 2017

Adding a new class to communicate Previews information

PreviewsUserData is a class that lives on the URLRequest and is copied
to the NavigationHandle via ChromeNavigationData.

Bug:  783917 
Change-Id: I7a86243bf11d764209db8bd5b8fe46423651446b
Reviewed-on: https://chromium-review.googlesource.com/752623
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515793}
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/loader/chrome_navigation_data.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/loader/chrome_navigation_data.h
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/loader/chrome_navigation_data_unittest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/loader/chrome_resource_dispatcher_host_delegate.h
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/previews/previews_infobar_tab_helper.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/previews/previews_infobar_tab_helper.h
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/chrome/browser/previews/previews_infobar_tab_helper_unittest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/content/previews_io_data.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/content/previews_io_data.h
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/content/previews_io_data_unittest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/core/BUILD.gn
[add] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/core/previews_user_data.cc
[add] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/core/previews_user_data.h
[add] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/components/previews/core/previews_user_data_unittest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/content/browser/loader/mojo_async_resource_handler_unittest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/content/browser/loader/resource_dispatcher_host_browsertest.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/content/public/browser/resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/91cd6ea5f5e7da627e19db952a8f4a576cbc422f/content/public/browser/resource_dispatcher_host_delegate.h

Status: Fixed (was: Assigned)

Comment 3 by efoo@chromium.org, Dec 5 2017

Components: Blink>Previews

Comment 4 by efoo@chromium.org, Dec 5 2017

Components: -UI>Browser>Previews

Sign in to add a comment