New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783914 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in safe_browsing::dmg::HFSBTreeIterator::Next

Project Member Reported by ClusterFuzz, Nov 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5386960305913856

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 2
Crash Address: 0x621000008900
Crash State:
  safe_browsing::dmg::HFSBTreeIterator::Next
  safe_browsing::dmg::HFSIterator::Next
  start
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5386960305913856

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 

Comment 1 by est...@chromium.org, Nov 10 2017

Cc: rsesek@chromium.org
Components: Services>Safebrowsing
Owner: jialiul@chromium.org
Status: Assigned (was: Untriaged)
Jialiu could you please help triage this bug? Thanks!

Comment 2 by vakh@chromium.org, Nov 10 2017

Cc: -rsesek@chromium.org jialiul@chromium.org
Owner: rsesek@chromium.org
rsesek@ -- can you please take a look? thanks.
Seems like a duplicate of 776307

Comment 4 by rsesek@chromium.org, Nov 10 2017

 Issue 776307  is fixed and verified by CF so I think this is different (maybe spotted an off-by-one bug).
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 11 2017

Labels: M-64
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 11 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 11 2017

Labels: Pri-1
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/643f77a80eff6a5dfd8ddee266f62e5d140fed78

commit 643f77a80eff6a5dfd8ddee266f62e5d140fed78
Author: Robert Sesek <rsesek@chromium.org>
Date: Tue Nov 14 00:19:10 2017

Fix heap overflow in safe_browsing::dmg::HFSBTreeIterator::Next().

The code was not properly checking that the length of the key string
contained within the buffer. The string uses UTF-16 (two-byte) units
but was treating the length as single-byte units. This switches the
code to use the size-checked GetLeafData<T> wrapper.

Bug:  783914 
Change-Id: I4f9207532181656e4865eb4c397cae5745b5785a
Reviewed-on: https://chromium-review.googlesource.com/767408
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516109}
[modify] https://crrev.com/643f77a80eff6a5dfd8ddee266f62e5d140fed78/chrome/utility/safe_browsing/mac/hfs.cc

Project Member

Comment 9 by ClusterFuzz, Nov 15 2017

ClusterFuzz has detected this issue as fixed in range 516099:516184.

Detailed report: https://clusterfuzz.com/testcase?key=5386960305913856

Fuzzer: libFuzzer_safe_browsing_hfs_fuzzer
Job Type: mac_libfuzzer_chrome_asan
Platform Id: mac

Crash Type: Heap-buffer-overflow READ 2
Crash Address: 0x621000008900
Crash State:
  safe_browsing::dmg::HFSBTreeIterator::Next
  safe_browsing::dmg::HFSIterator::Next
  start
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=509376:509426
Fixed: https://clusterfuzz.com/revisions?job=mac_libfuzzer_chrome_asan&range=516099:516184

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5386960305913856

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 15 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5386960305913856 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 15 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment