New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783908 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 783621
Owner: ----
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

33.3%-61.7% improvement in system_health.memory_mobile at 515102:515129

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

A large improvement, I wonder what caused that?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783908

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=1b3adcc9dcbd153363e3301069b9679a697f52ace51d8db47d9b398b7e00ec40


Bot(s) for this bug's original alert(s):

android-webview-nexus6
chromium-rel-win10
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

Mergedinto: 783621
Status: Duplicate (was: Untriaged)

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Kouhei Ueno
  Commit : e1cfaee91ad08478fbd956fcd73d570032702397
  Date   : Thu Nov 09 08:23:01 2017
  Subject: Revert "Make script cache hits async"

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/load_news/load_news_cnn
  Change       : 33.25% | 40799828.0 -> 27233876.0

Revision             Result                    N
chromium@515117      40799828 +- 0.0           6      good
chromium@515120      40799828 +- 0.0           9      good
chromium@515121      30248532 +- 16919715      9      bad       <--
chromium@515122      27233876 +- 0.0           6      bad
chromium@515123      27233876 +- 0.0           6      bad
chromium@515129      27233876 +- 0.0           6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.cnn system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963282304339348576


For feedback, file a bug with component Speed>Bisection

Sign in to add a comment