New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783900 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Disable mounting Flash components in m-63 and m-62

Project Member Reported by kerrnel@chromium.org, Nov 10 2017

Issue description

Because of the reference counting issues in the kernel, which prevent Flash components from being unmounted on kernels 3.8 and 3.10, we will disable mounting those components on m-63. Because the change is low risk, we should merge it to m-62 to pick if we spin a new build. We should not spin any m-62 builds just for this change.

Note to release managers: the change is for m-63 only, so there will be no submission to m-64. 
 
Labels: -Merge-Request-63 Merge-Approved-62 Merge-Approved-63
Assuming this is a trivial one line sort of safe change, please feel free to merge at your convenience.
Thanks. It is indeed a one line config file change.

Comment 3 by vapier@chromium.org, Nov 10 2017

will Chrome care if it attempts to talk on dbus to imageloader and it's not there ?  i understand we're turning off pushing of components to these older branches, but seems like something to consider "just in case".
Imageloader will still be present, I'm just going to delete imageloader.conf installation from the ebuild file.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 13 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/ba8ba238fd877d815619c37ea80b67d3f1c381ef

commit ba8ba238fd877d815619c37ea80b67d3f1c381ef
Author: Greg Kerr <kerrnel@chromium.org>
Date: Mon Nov 13 17:18:26 2017

Disable Flash component mounting at boot.

This disables the init script which mounts Flash component updates at
boot, due to a bug in kernels 3.8 and 3.10, where the disk image is not
unmounted at shutdown.

BUG= chromium:783900 
TEST=emerge-${BOARD} imageloader

Change-Id: Id5f9734761e599bcf041bdbc8f955e8b2f27a7a8
Reviewed-on: https://chromium-review.googlesource.com/764571
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Trybot-Ready: Greg Kerr <kerrnel@chromium.org>

[modify] https://crrev.com/ba8ba238fd877d815619c37ea80b67d3f1c381ef/chromeos-base/imageloader/imageloader-9999.ebuild

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 13 2017

Labels: merge-merged-release-R62-9901.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/27a54378c8cd92e8dc3ab9487f6cc2f81e574486

commit 27a54378c8cd92e8dc3ab9487f6cc2f81e574486
Author: Greg Kerr <kerrnel@chromium.org>
Date: Mon Nov 13 17:18:30 2017

Disable Flash component mounting at boot.

This disables the init script which mounts Flash component updates at
boot, due to a bug in kernels 3.8 and 3.10, where the disk image is not
unmounted at shutdown.

BUG= chromium:783900 
TEST=emerge-${BOARD} imageloader

Change-Id: Ic7418119ea43c4e709dbdbd7aaad1598142837c7
Reviewed-on: https://chromium-review.googlesource.com/764493
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Tested-by: Greg Kerr <kerrnel@chromium.org>
Trybot-Ready: Greg Kerr <kerrnel@chromium.org>

[modify] https://crrev.com/27a54378c8cd92e8dc3ab9487f6cc2f81e574486/chromeos-base/imageloader/imageloader-9999.ebuild

Project Member

Comment 7 by sheriffbot@chromium.org, Nov 14 2017

Cc: bhthompson@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-62 -Merge-Approved-63
Status: Fixed (was: Started)

Sign in to add a comment