TestNonCompositedOverlayScrollbarsFade is failing |
||
Issue descriptionThe following fails reliably locally: out/Debug/webkit_unit_tests --gtest_filter=All/ScrollbarsTestWithVirtualTimer.* [66848:775:1110/115936.287200:19690847774643:FATAL:renderer_scheduler_impl.cc(1541)] Check failed: !pair.first->HasActiveFence(). 0 base::debug::StackTrace::StackTrace(unsigned long) + 174 1 base::debug::StackTrace::StackTrace(unsigned long) + 29 2 base::debug::StackTrace::StackTrace() + 28 3 logging::LogMessage::~LogMessage() + 479 4 logging::LogMessage::~LogMessage() + 21 5 blink::scheduler::RendererSchedulerImpl::VirtualTimePaused() + 1203 6 blink::scheduler::RendererSchedulerImpl::EnableVirtualTime() + 1387 7 blink::scheduler::WebViewSchedulerImpl::EnableVirtualTime() + 25 8 blink::(anonymous namespace)::ScrollbarsTestWithVirtualTimer_TestNonCompositedOverlayScrollbarsFade_Test::TestBody() + 89 This test is also flaky on the bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_unit_tests&tests=TestNonCompositedOverlayScrollbarsFade
,
Nov 13 2017
I don't understand why the test is having to call DisableVirtualTimeForTesting. That function appears to have some rough edges when it comes to throttable task queues. Anyway this seems to work and doesn't seem to be flaky when run locally: https://chromium-review.googlesource.com/#/c/chromium/src/+/765974
,
Nov 13 2017
we call DisableVirtualTimeForTesting because VirtualTimeTest do this and ScrollbarsTest are SimTest.
,
Nov 13 2017
Looks like it's not needed anymore.
,
Nov 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/290b5ecfbddcdf086aeccf2c8f1bb0c6175c91dc commit 290b5ecfbddcdf086aeccf2c8f1bb0c6175c91dc Author: Alex Clarke <alexclarke@chromium.org> Date: Mon Nov 20 16:21:24 2017 Fix TestNonCompositedOverlayScrollbarsFade Bug: 783898 Change-Id: Ifa0fcbe77bbf9ca952cbd873cca14e3b6e0c7ad0 Reviewed-on: https://chromium-review.googlesource.com/765974 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#517840} [modify] https://crrev.com/290b5ecfbddcdf086aeccf2c8f1bb0c6175c91dc/third_party/WebKit/Source/core/layout/ScrollbarsTest.cpp
,
Nov 28 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by chaopeng@chromium.org
, Nov 10 2017