Update global search engine preopulate list |
|||
Issue descriptionIt's been a number of years since we did a global update. We should do one. Rachel, do you know who should own this? We've gotten internal help crunching the data on this in the past, but I think Tyler PMed that and he's no longer on Chrome.
,
Nov 12
,
Nov 12
You probably want to coordinate with cthomp@, owner of bug 869667.
,
Dec 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/98b2af784450beb20cdb26cbee60168891cec4ec commit 98b2af784450beb20cdb26cbee60168891cec4ec Author: Orin Jaworski <orinj@chromium.org> Date: Wed Dec 12 19:06:23 2018 Update default search engines list per country from new data The default search engine (DSE) list is being refreshed from recently collected data. This CL is focusing first on countries for which a DSE list is already in place. Existing engine registrations will be kept intact, and only new engines are being added. The list of engine references for each country is being completely replaced based on new usage statistics, and unreferenced engine registrations are removed. Bug: 783890 Change-Id: Ie13eaa91d4a62eb581375f6dc00c556c7c536885 Reviewed-on: https://chromium-review.googlesource.com/c/1345542 Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615987} [modify] https://crrev.com/98b2af784450beb20cdb26cbee60168891cec4ec/components/search_engines/prepopulated_engines.json [modify] https://crrev.com/98b2af784450beb20cdb26cbee60168891cec4ec/components/search_engines/search_engine_type.h [modify] https://crrev.com/98b2af784450beb20cdb26cbee60168891cec4ec/components/search_engines/template_url_prepopulate_data.cc [modify] https://crrev.com/98b2af784450beb20cdb26cbee60168891cec4ec/components/search_engines/template_url_prepopulate_data_unittest.cc
,
Dec 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2adbc9fb644de825056ff9bc18514e34635549bb commit 2adbc9fb644de825056ff9bc18514e34635549bb Author: Orin Jaworski <orinj@chromium.org> Date: Thu Dec 13 01:01:42 2018 In DSE, remove clang-format directives and re-format prepopulate lists This is no-op CL to update to the new behavior of 'git cl format' that puts each array initializer item on its own line. By removing the clang-format directives, we can ensure that future changes will benefit from the automatic formatting logic and adhere to standards. Bug: 783890 Change-Id: I8887f8951acb6d35102b18f7eca9ab6ed88a77bf Reviewed-on: https://chromium-review.googlesource.com/c/1374459 Reviewed-by: Kevin Bailey <krb@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#616132} [modify] https://crrev.com/2adbc9fb644de825056ff9bc18514e34635549bb/components/search_engines/template_url_prepopulate_data.cc
,
Jan 7
Verification and sanity-checking for each locality would be nice, but from a technical standpoint the work is complete.
,
Jan 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ea1ac17f2cae08abfd3d6e88f9ad018c798b979 commit 3ea1ac17f2cae08abfd3d6e88f9ad018c798b979 Author: Orin Jaworski <orinj@chromium.org> Date: Wed Jan 16 00:34:38 2019 Update new DSE registrations CocCoc and Parsijoo to HTTPS These two search engines provide both HTTP and HTTPS endpoints, and HTTPS is preferred for security, so the new default search engine registrations are updated to use HTTPS. The unit test is also updated to remove their HTTP exceptions. Bug: 783890 Change-Id: Ib92301e208e2b5b1b9570c00b3aed868a0ec3026 Reviewed-on: https://chromium-review.googlesource.com/c/1412975 Reviewed-by: Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#622930} [modify] https://crrev.com/3ea1ac17f2cae08abfd3d6e88f9ad018c798b979/components/search_engines/prepopulated_engines.json [modify] https://crrev.com/3ea1ac17f2cae08abfd3d6e88f9ad018c798b979/components/search_engines/template_url_prepopulate_data_unittest.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by sheriffbot@chromium.org
, Nov 12Status: Untriaged (was: Available)