New issue
Advanced search Search tips

Issue 783853 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature

Blocked on:
issue v8:7503

Blocking:
issue 818642



Sign in to add a comment

Reduce SharedFunctionInfo size for uncompiled functions

Project Member Reported by u...@chromium.org, Nov 10 2017

Issue description

About half of the SharedFunctionInfo created in Gmail are not compiled and not called.

By reducing size of uncompiled SharedFunctionInfos we can save up to 5MB in Gmail.
 
I think we can merge code, function-data and preparsed-scope-data as they aren't used at the same time.

ConstructStubOffset we can probably replace with a bitfield if there's still some place somewhere.

I don't think we need instance_class_name anymore since it's only used from function templates; and we can fetch class_name from the template if there is one.

I'm not sure we actually need function_literal_id on the SFI since it seems we only use it from literals which have the ID. Either we index with literal->id() into a list of SFI to find the matching SFI, or we store the created SFI for literal in that list. We might want to have it only in debugmode to verify we're finding the correct one.

Comment 2 by u...@chromium.org, Nov 13 2017

Thanks, Toon. If we get rid of five slots in SFI, then this will save about 3MB.
Components: -Blink>JavaScript Blink>JavaScript>Runtime
Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Owner: marja@chromium.org
Status: Assigned (was: Available)
I'm not sure about merging code and function-data -- e.g. code stores the InterpreterEntryTrampoline when function-data is the BytecodeArray, and we have quite a bit of code that assumes that you can jump to the shared function code. Probably a similar story for Asm->Wasm data.

We're also considering using function_literal_id as a SFI identifier if we were to do "incremental code caching" (one of our options for improving code cache behaviour, not our current main one but one that I'd prefer to keep open).
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5aa6f58952047bf3eb72e8a016ae1520b62176fe

commit 5aa6f58952047bf3eb72e8a016ae1520b62176fe
Author: Leszek Swirski <leszeks@chromium.org>
Date: Fri Nov 17 13:14:21 2017

[cleanup] Move preparsed data into function data in SFI

Since we only ever have preparsed scope info data for functions that
haven't been parsed yet, it never overlaps with there being other
function data (such as a bytecode array). So, we can merge the two
fields.

This drops the SharedFunctionInfo size by one pointer.

Bug: chromium:783853
Change-Id: I7166010271cf661b04d3d118ac87c65c79555f96
Reviewed-on: https://chromium-review.googlesource.com/774863
Reviewed-by: Toon Verwaest <verwaest@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49445}
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/compiler.cc
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/factory.cc
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/objects-debug.cc
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/objects.cc
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/5aa6f58952047bf3eb72e8a016ae1520b62176fe/src/objects/shared-function-info.h

Blocking: 818642
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/520b025f721e432da28f04748952746e57333572

commit 520b025f721e432da28f04748952746e57333572
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Mar 20 13:14:53 2018

Remove SFI code field

Remove the SharedFunctionInfo code field, inferring the code object
from the function_data field instead. In some cases, the function_data
field can now hold a Code object (e.g. some WASM cases).

Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I1219a4d6aa5abaa9fee54dda883da7a3186e347a
Reviewed-on: https://chromium-review.googlesource.com/952452
Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52064}
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/api.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/asmjs/asm-js.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/bailout-reason.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/bootstrapper.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/builtins-console.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/builtins.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/code-stub-assembler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/code-stub-assembler.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler-dispatcher/optimizing-compile-dispatcher.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler/code-assembler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler/code-assembler.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/debug/debug-evaluate.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/debug/debug.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/debug/liveedit.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/execution.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/factory.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/factory.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/frames.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/interpreter/interpreter.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/log.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/objects-debug.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/objects-printer.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/objects.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/objects/shared-function-info.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/runtime/runtime-function.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/runtime/runtime-internal.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/runtime/runtime-test.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/snapshot/deserializer.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/snapshot/snapshot-common.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/src/snapshot/snapshot.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/cctest/test-feedback-vector.h
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/unittests/compiler/js-call-reducer-unittest.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/test/unittests/test-helpers.cc
[modify] https://crrev.com/520b025f721e432da28f04748952746e57333572/tools/gen-postmortem-metadata.py

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604

commit 9b4d8fe41f6b7f7d27e1622f6e5e29092f829604
Author: Leszek Swirski <leszeks@chromium.org>
Date: Tue Mar 20 13:47:34 2018

Revert "Remove SFI code field"

This reverts commit 520b025f721e432da28f04748952746e57333572.

Reason for revert: Breaks internal-snapshot build: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20internal%20snapshot/builds/14603

Original change's description:
> Remove SFI code field
> 
> Remove the SharedFunctionInfo code field, inferring the code object
> from the function_data field instead. In some cases, the function_data
> field can now hold a Code object (e.g. some WASM cases).
> 
> Bug: chromium:783853
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: I1219a4d6aa5abaa9fee54dda883da7a3186e347a
> Reviewed-on: https://chromium-review.googlesource.com/952452
> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52064}

TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,leszeks@chromium.org,bmeurer@chromium.org,verwaest@chromium.org

Change-Id: Iaf464ed29ba4317bbbb255c1aec76fb65cddba84
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/970647
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52066}
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/api.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/asmjs/asm-js.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/bailout-reason.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/bootstrapper.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/builtins-console.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/builtins.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/code-stub-assembler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/code-stub-assembler.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler-dispatcher/optimizing-compile-dispatcher.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler/code-assembler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler/code-assembler.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/debug/debug-evaluate.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/debug/debug.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/debug/liveedit.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/execution.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/factory.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/factory.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/frames.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/interpreter/interpreter.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/log.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/objects-debug.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/objects-printer.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/objects.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/objects/shared-function-info.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/runtime/runtime-function.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/runtime/runtime-internal.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/runtime/runtime-test.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/snapshot/deserializer.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/snapshot/snapshot-common.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/src/snapshot/snapshot.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/cctest/test-feedback-vector.h
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/unittests/compiler/js-call-reducer-unittest.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/test/unittests/test-helpers.cc
[modify] https://crrev.com/9b4d8fe41f6b7f7d27e1622f6e5e29092f829604/tools/gen-postmortem-metadata.py

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d8f564eac6152c05f6521572b6f06146c2e99eb1

commit d8f564eac6152c05f6521572b6f06146c2e99eb1
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Mar 22 11:16:20 2018

Reland: Remove SFI code field

Remove the SharedFunctionInfo code field, inferring the code object
from the function_data field instead. In some cases, the function_data
field can now hold a Code object (e.g. some WASM cases).

(Reland of https://chromium-review.googlesource.com/952452)

TBR=mstarzinger@chromium.org

Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I10ea5be7ceed1b51362a2fad9be7397624d69343
Reviewed-on: https://chromium-review.googlesource.com/970649
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52136}
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/api.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/asmjs/asm-js.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/bailout-reason.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/bootstrapper.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/builtins-console.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/builtins.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/code-stub-assembler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/code-stub-assembler.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler-dispatcher/optimizing-compile-dispatcher.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler/code-assembler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler/code-assembler.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/debug/debug-evaluate.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/debug/debug.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/debug/liveedit.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/execution.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/factory.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/factory.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/frames.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/interpreter/interpreter.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/log.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/objects-debug.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/objects-printer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/objects.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/objects/shared-function-info.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/runtime/runtime-function.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/runtime/runtime-internal.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/runtime/runtime-test.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/deserializer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/serializer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/serializer.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/snapshot-common.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/snapshot.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/src/snapshot/startup-serializer.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/test-feedback-vector.h
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/cctest/test-serialize.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/unittests/compiler/js-call-reducer-unittest.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/test/unittests/test-helpers.cc
[modify] https://crrev.com/d8f564eac6152c05f6521572b6f06146c2e99eb1/tools/gen-postmortem-metadata.py

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/48f89fbdc4f47ae7819922d308606ff05c92809f

commit 48f89fbdc4f47ae7819922d308606ff05c92809f
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Mar 22 12:56:54 2018

Revert "Reland: Remove SFI code field"

This reverts commit d8f564eac6152c05f6521572b6f06146c2e99eb1.

Reason for revert: Breaks mac asan (https://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/17067)

Original change's description:
> Reland: Remove SFI code field
> 
> Remove the SharedFunctionInfo code field, inferring the code object
> from the function_data field instead. In some cases, the function_data
> field can now hold a Code object (e.g. some WASM cases).
> 
> (Reland of https://chromium-review.googlesource.com/952452)
> 
> TBR=mstarzinger@chromium.org
> 
> Bug: chromium:783853
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: I10ea5be7ceed1b51362a2fad9be7397624d69343
> Reviewed-on: https://chromium-review.googlesource.com/970649
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52136}

TBR=yangguo@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,leszeks@chromium.org

Change-Id: I348ec7a9d837a7b068fd08312b77e87abf21be7b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/975305
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52143}
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/api.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/asmjs/asm-js.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/bailout-reason.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/bootstrapper.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/builtins-console.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/builtins.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/code-stub-assembler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/code-stub-assembler.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler-dispatcher/optimizing-compile-dispatcher.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler/code-assembler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler/code-assembler.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/debug/debug-evaluate.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/debug/debug.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/debug/liveedit.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/execution.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/factory.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/factory.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/frames.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/interpreter/interpreter.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/log.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/objects-debug.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/objects-printer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/objects.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/objects/shared-function-info.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/runtime/runtime-function.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/runtime/runtime-internal.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/runtime/runtime-test.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/deserializer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/serializer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/serializer.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/snapshot-common.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/snapshot.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/src/snapshot/startup-serializer.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/test-feedback-vector.h
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/cctest/test-serialize.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/unittests/compiler/js-call-reducer-unittest.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/test/unittests/test-helpers.cc
[modify] https://crrev.com/48f89fbdc4f47ae7819922d308606ff05c92809f/tools/gen-postmortem-metadata.py

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/51ded9d3c0dc430217253595027c6ed207d8cc2d

commit 51ded9d3c0dc430217253595027c6ed207d8cc2d
Author: Leszek Swirski <leszeks@chromium.org>
Date: Thu Mar 22 17:06:06 2018

Reland^2: Remove SFI code field

This is a reland of d8f564eac6152c05f6521572b6f06146c2e99eb1

TBR=mstarzinger@chromium.org,yangguo@chromium.org,jgruber@chromium.org

Original change's description:
> Reland: Remove SFI code field
>
> Remove the SharedFunctionInfo code field, inferring the code object
> from the function_data field instead. In some cases, the function_data
> field can now hold a Code object (e.g. some WASM cases).
>
> (Reland of https://chromium-review.googlesource.com/952452)
>
> TBR=mstarzinger@chromium.org
>
> Bug: chromium:783853
> Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
> Change-Id: I10ea5be7ceed1b51362a2fad9be7397624d69343
> Reviewed-on: https://chromium-review.googlesource.com/970649
> Commit-Queue: Leszek Swirski <leszeks@chromium.org>
> Reviewed-by: Yang Guo <yangguo@chromium.org>
> Reviewed-by: Jakob Gruber <jgruber@chromium.org>
> Reviewed-by: Leszek Swirski <leszeks@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52136}

Bug: chromium:783853
Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I5187851b923e9a92f43daf8cb99e662786cbb839
Reviewed-on: https://chromium-review.googlesource.com/975942
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52159}
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/api.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/asmjs/asm-js.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/bailout-reason.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/bootstrapper.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/builtins-console.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/builtins.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/code-stub-assembler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/code-stub-assembler.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler-dispatcher/optimizing-compile-dispatcher.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler/code-assembler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler/code-assembler.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler/js-call-reducer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler/js-typed-lowering.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/compiler/wasm-compiler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/debug/debug-evaluate.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/debug/debug.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/debug/liveedit.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/execution.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/factory.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/factory.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/frames.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/interpreter/interpreter.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/log.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/objects-debug.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/objects-printer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/objects.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/objects/shared-function-info.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/runtime/runtime-compiler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/runtime/runtime-function.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/runtime/runtime-internal.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/runtime/runtime-test.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/deserializer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/partial-serializer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/serializer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/serializer.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/snapshot-common.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/snapshot.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/startup-serializer.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/src/snapshot/startup-serializer.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/cctest.status
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/test-code-stub-assembler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/test-feedback-vector.h
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/test-field-type-tracking.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/test-heap-profiler.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/cctest/test-serialize.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/unittests/compiler/js-call-reducer-unittest.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/test/unittests/test-helpers.cc
[modify] https://crrev.com/51ded9d3c0dc430217253595027c6ed207d8cc2d/tools/gen-postmortem-metadata.py

Project Member

Comment 13 by bugdroid1@chromium.org, Mar 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a29de090c9b640e5516ea7c6b9bda94869b444cc

commit a29de090c9b640e5516ea7c6b9bda94869b444cc
Author: Junliang Yan <jyan@ca.ibm.com>
Date: Thu Mar 22 22:38:27 2018

PPC/s390: Reland^2: Remove SFI code field

Port 51ded9d3c0dc430217253595027c6ed207d8cc2d

Original Commit Message:

    This is a reland of d8f564eac6152c05f6521572b6f06146c2e99eb1

    Original change's description:
    > Reland: Remove SFI code field
    >
    > Remove the SharedFunctionInfo code field, inferring the code object
    > from the function_data field instead. In some cases, the function_data
    > field can now hold a Code object (e.g. some WASM cases).
    >
    > (Reland of https://chromium-review.googlesource.com/952452)
    >
    > TBR=mstarzinger@chromium.org
    >
    > Bug: chromium:783853
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    > Change-Id: I10ea5be7ceed1b51362a2fad9be7397624d69343
    > Reviewed-on: https://chromium-review.googlesource.com/970649
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#52136}

R=leszeks@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: I86c5a46a866830a2150ff9366be12a09f111240f
Reviewed-on: https://chromium-review.googlesource.com/976624
Reviewed-by: Joran Siu <joransiu@ca.ibm.com>
Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#52165}
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/ppc/assembler-ppc.h
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/ppc/macro-assembler-ppc.cc
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/ppc/macro-assembler-ppc.h
[modify] https://crrev.com/a29de090c9b640e5516ea7c6b9bda94869b444cc/src/s390/macro-assembler-s390.h

Blockedon: v8:7503
Cc: rmcilroy@chromium.org
Owner: leszeks@chromium.org
Project Member

Comment 16 by bugdroid1@chromium.org, Jun 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5

commit c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Thu Jun 28 10:08:52 2018

[sfi] Remove DebugInfo field in SharedFunctionInfo.

Merges DebugInfo field into the function_identifier field, storing the function
identifier in the DebugInfo. Also moves some debugging_hints bits to the SFI flags,
and others to the DebugInfo. Finally, changes the logic to store debugger patched
bytecode array on the SFI instead of the DebugInfo, simplifying the logic in the
InterpreterEntryTrampoline.

BUG=chromium:818642,chromium:783853
TBR=hpayer@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: If440080c0f08fac4fb96f5e18dcc0eb9b86d4821
Reviewed-on: https://chromium-review.googlesource.com/1115819
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Reviewed-by: Leszek Swirski <leszeks@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54081}
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/api.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/arm/builtins-arm.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/arm64/builtins-arm64.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/builtins-internal-gen.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/ia32/builtins-ia32.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/mips/builtins-mips.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/mips64/builtins-mips64.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/ppc/builtins-ppc.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/s390/builtins-s390.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/builtins/x64/builtins-x64.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/debug/debug-evaluate.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/debug/debug-evaluate.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/debug/debug.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/debug/debug.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/debug/liveedit.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/heap/factory.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/heap/heap-inl.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/heap/setup-heap-internal.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects-debug.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects-printer.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects/debug-objects-inl.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects/debug-objects.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects/debug-objects.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/objects/shared-function-info.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/profiler/heap-snapshot-generator.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/runtime/runtime-debug.cc
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/runtime/runtime.h
[modify] https://crrev.com/c51bcd17bb4da87e1b9bf067351f0fc5cce4bbd5/src/snapshot/code-serializer.cc

Project Member

Comment 17 by bugdroid1@chromium.org, Jul 4

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ce409375b3d2a179508a5dfe4d50d9fdf052c803

commit ce409375b3d2a179508a5dfe4d50d9fdf052c803
Author: Ross McIlroy <rmcilroy@chromium.org>
Date: Wed Jul 04 16:53:37 2018

[sfi] Reduce FunctionTokenPosition and ExpectedNofProperties to 16 bits.

Changes SharedFunctionInfo to store a function_token_offset, relative
to the start_position, instead of the full function_token_position.
This enables us to reduce both FunctionTokenPosition and
ExpectedNofProperties to 16 bits each, saving 32 bits per SFI.

BUG=chromium:818642,chromium:783853
TBR=yangguo@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
Change-Id: I45aefcec605c1da502053c23c73564ceaed6c9b5
Reviewed-on: https://chromium-review.googlesource.com/1122982
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54220}
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/include/v8.h
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/src/debug/liveedit.cc
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/src/heap/factory.cc
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/src/objects.cc
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/src/objects/shared-function-info-inl.h
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/src/objects/shared-function-info.h
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/test/mjsunit/harmony/function-tostring.js
[modify] https://crrev.com/ce409375b3d2a179508a5dfe4d50d9fdf052c803/tools/gen-postmortem-metadata.py

Sign in to add a comment