MacViews credit card save dialog does not disappear on tab change |
||||
Issue descriptionReproduction steps: 1) With #secondary-ui-md and #enable-macviews-credit-card-dialogs enabled, spawn a credit card save dialog. Easiest case is https://dump-truck.appspot.com/usecase-address_and_cc_on_same_page/address_and_cc.html and using default values. 2) Once the bubble appears, change tabs. Expected behavior: The bubble goes away. This is true for the old Cocoa implementation, as well as other platforms when #secondary-ui-md is enabled. (Tested on Linux and Windows in M62.) Actual behavior: The bubble stays until it gains and loses focus (see screenshot).
,
Nov 10 2017
Easier repro: out/Default/browser_tests --gtest_filter=BrowserDialogTest.Invoke --dialog=SaveCardBubbleControllerImplTest.InvokeDialog_Server_WithCvcStep --interactive Then create a new tab
,
Nov 10 2017
,
Nov 15 2017
Elly or Trent, it seems that once the bubble gets focus, changing tabs will properly dismiss it. We don't seem to be having this problem with the password save bubble (https://rsolomakhin.github.io/autofill has an easy way to trigger the save password bubble), so it's perhaps something that the save card bubble is doing wrong?
,
Nov 15 2017
Any help is appreciated.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a830d224129d0c04cfcf65a3f2c4091a8b30df47 commit a830d224129d0c04cfcf65a3f2c4091a8b30df47 Author: Mathieu Perreault <mathp@chromium.org> Date: Fri Nov 17 04:59:30 2017 [Autofill] Observe the web contents state and hide the save card bubble Using more of WebContentsObserver to hide the bubble when the tab is switched or closed. Removing the TabStripModelObserver because the WebContentsObserver is sufficient. Bug: 783852 Test: Manual through interactive browser_tests Change-Id: I14cb528ad04901cb9ca2526207673036a927b9ce Reviewed-on: https://chromium-review.googlesource.com/775939 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#517306} [modify] https://crrev.com/a830d224129d0c04cfcf65a3f2c4091a8b30df47/chrome/browser/ui/autofill/save_card_bubble_controller_impl.cc [modify] https://crrev.com/a830d224129d0c04cfcf65a3f2c4091a8b30df47/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h [modify] https://crrev.com/a830d224129d0c04cfcf65a3f2c4091a8b30df47/chrome/browser/ui/autofill/save_card_bubble_controller_impl_browsertest.cc [modify] https://crrev.com/a830d224129d0c04cfcf65a3f2c4091a8b30df47/chrome/browser/ui/views/autofill/save_card_icon_view.cc [modify] https://crrev.com/a830d224129d0c04cfcf65a3f2c4091a8b30df47/chrome/browser/ui/views/autofill/save_card_icon_view.h
,
Nov 17 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by jsaul@google.com
, Nov 10 2017