New issue
Advanced search Search tips

Issue 783850 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Dec 2017
Cc:
btolsch@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature

Blocking:
issue 758005



Sign in to add a comment

Add UMA metrics for local screens casting

Project Member Reported by taku...@chromium.org, Nov 10 2017 
Add metrics for tracking:
- The type of sink the user is Casting to (e.g. Chromecast, Hangout, wired display)
- The number of wired display sinks reported by the MRP, given a Presentation API URL
- The outcome (success/error code) of attempting to present to a local screen
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55f83effaa0ba37bbe32c312ea32a58e687275ad

commit 55f83effaa0ba37bbe32c312ea32a58e687275ad
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Sat Nov 18 00:39:15 2017

[Media Router] Add UMA metrics for recording wired display sink count

WiredDisplayMediaRouteProvider will record the number of sinks each time it notifies MediaRouter of sink updates.

Bug:  783850 
Change-Id: Ifc7c6e21b9253016ba3ec139ce50e11f313a08bf
Reviewed-on: https://chromium-review.googlesource.com/767854
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517634}
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/discovery/media_sink_discovery_metrics.cc
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/discovery/media_sink_discovery_metrics.h
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/discovery/media_sink_discovery_metrics_unittest.cc
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/mojo/wired_display_media_route_provider.cc
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/chrome/browser/media/router/mojo/wired_display_media_route_provider.h
[modify] https://crrev.com/55f83effaa0ba37bbe32c312ea32a58e687275ad/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b14c00e84dead2ec8e16444e4c769f255b3c7fd0

commit b14c00e84dead2ec8e16444e4c769f255b3c7fd0
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Thu Dec 14 20:38:01 2017

[Media Router] Add UMA metrics to record sink type when creating a route

We will record the type of the sink (Cast, Audio, Hangouts, etc.) when Media Router attempts to create a route.

Bug:  783850 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I697af8c9d032bfbd0c6033a87261b75a9f408982
Reviewed-on: https://chromium-review.googlesource.com/764188
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524163}
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/ash/public/interfaces/cast_config.mojom
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/ash/system/cast/tray_cast.cc
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/media/router/media_router_metrics.cc
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/media/router/media_router_metrics.h
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/media/router/media_router_metrics_unittest.cc
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/resources/media_router/media_router_data.js
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/common/media_router/media_sink.h
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/common/media_router/mojo/media_router.mojom
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/chrome/common/media_router/mojo/media_router_struct_traits.h
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/b14c00e84dead2ec8e16444e4c769f255b3c7fd0/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/554c43ad8b3b162d2e37c7ca847c1550fc72a05f

commit 554c43ad8b3b162d2e37c7ca847c1550fc72a05f
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Mon Dec 18 21:05:51 2017

[Media Router] Add UMA metrics to record route results for wired displays

This CL adds these metrics that are recorded when user creates, joins or terminates a route with the wired display MediaRouteProvider:
  MediaRouter.Provider.CreateRoute.Result.WiredDisplay
  MediaRouter.Provider.JoinRoute.Result.WiredDisplay
  MediaRouter.Provider.TerminateRoute.Result.WiredDisplay

The existing metrics that record these events are scoped to the extension MRP, or when the MRP type cannot be deduced.

Bug:  783850 
Change-Id: I1d2d4506b9014d4a7c744ab44a95f9456bd9c612
Reviewed-on: https://chromium-review.googlesource.com/827600
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524792}
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/chrome/browser/media/router/mojo/media_router_mojo_impl.cc
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/chrome/browser/media/router/mojo/media_router_mojo_impl.h
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/chrome/browser/media/router/mojo/media_router_mojo_metrics.cc
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/chrome/browser/media/router/mojo/media_router_mojo_metrics.h
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/chrome/browser/media/router/mojo/media_router_mojo_metrics_unittest.cc
[modify] https://crrev.com/554c43ad8b3b162d2e37c7ca847c1550fc72a05f/tools/metrics/histograms/histograms.xml

Comment 4 by taku...@chromium.org, Dec 19 2017

Status: Fixed (was: Started)

Comment 5 by taku...@chromium.org, Jan 8 2018

Labels: Hotlist-LocalScreenCasting
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6e5f181c9de82b90b499d7a1577e8ccaac7816a

commit c6e5f181c9de82b90b499d7a1577e8ccaac7816a
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Mar 07 21:05:28 2018

[Media Router] Use the correct metric name for sink selection

The histogram name for sink type selection was not the same as the one
in histograms.xml, and was not being recorded as a result. This CL
fixes that.

Bug:  783850 
Change-Id: Ia6c1d983c8933ae9c0dedd83cbe0d1ef7df13db1
Reviewed-on: https://chromium-review.googlesource.com/951895
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541578}
[modify] https://crrev.com/c6e5f181c9de82b90b499d7a1577e8ccaac7816a/chrome/browser/media/router/media_router_metrics.cc
►

Sign in to add a comment