New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 783849 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

49.4% improvement in system_health.memory_mobile at 515123:515167

Project Member Reported by alexclarke@chromium.org, Nov 10 2017

Issue description

Suspiciously large improvement, did something break?
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Nov 10 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=783849

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6ce896f97f2545dd18a6e63a21766b3b9dd8adc0751c4dd809a8884b5eea1ff5


Bot(s) for this bug's original alert(s):

android-nexus5
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 11 2017

Cc: nedngu...@google.com
Owner: nedngu...@google.com
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author nednguyen@google.com ===

Hi nednguyen@google.com, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Nghia Nguyen
  Commit : 564e33d345ee080be36ad0e6b6107afbcd09df4d
  Date   : Tue Nov 07 14:06:23 2017
  Subject: Update wprgo binaries to latest version

Bisect Details
  Configuration: android_nexus5_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:chrome:all_processes:reported_by_chrome:skia:effective_size_avg/browse_news/browse_news_cnn
  Change       : 49.62% | 2308779.33333 -> 1163234.66667

Revision                                 Result                  N
chromium@515122                          2308779 +- 57436.1      6      good
chromium@515145                          2335105 +- 85444.1      6      good
chromium@515148                          2326412 +- 57143.9      6      good
chromium@515148,catapult@a7fb6add75      2342338 +- 3002.2       6      good
chromium@515148,catapult@b33d83ad5d      2319271 +- 62301.8      6      good
chromium@515148,catapult@564e33d345      1163288 +- 110.851      6      bad       <--
chromium@515148,catapult@c169bba255      1163224 +- 0.0          6      bad
chromium@515149                          1162991 +- 1457.51      6      bad
chromium@515150                          1162647 +- 2014.68      6      bad
chromium@515151                          1162980 +- 1442.03      6      bad
chromium@515156                          1162917 +- 1714.98      6      bad
chromium@515167                          1163235 +- 36.9504      6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.news.cnn system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8963288771074406624


For feedback, file a bug with component Speed>Bisection
Cc: kouhei@chromium.org
Status: WontFix (was: Assigned)
The real change is https://chromium-review.googlesource.com/c/catapult/+/729283, which is expectedly to cause "improvement" as it describes.
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, Nov 13 2017

Cc: tdresser@google.com
 Issue 784345  has been merged into this issue.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 16 2017

 Issue 785729  has been merged into this issue.
Project Member

Comment 7 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

Cc: u...@chromium.org
 Issue 787441  has been merged into this issue.
Project Member

Comment 8 by 42576172...@developer.gserviceaccount.com, Nov 21 2017

Cc: mvstanton@google.com mvstan...@chromium.org
 Issue 787415  has been merged into this issue.
Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Nov 22 2017

 Issue 785721  has been merged into this issue.
Project Member

Comment 10 by 42576172...@developer.gserviceaccount.com, Nov 22 2017

 Issue 787449  has been merged into this issue.

Sign in to add a comment