[Chrome Home] Use buttons in promo instead of toggle/switch |
|||||||||
Issue descriptionThe promo dialog should use buttons instead of a toggle switch. Spec here: https://docs.google.com/presentation/d/1PqdycsbVbaU70h9HCbi7VF2lIS1d7pFwxu53fxlnF1A/edit#slide=id.g27137619f1_0_101
,
Nov 16 2017
Great - can we mark this as fixed?
,
Nov 16 2017
,
Nov 17 2017
Hey Matt, could we actually change the "Not now" string to "Not yet"? Sorry, I had updated this in the mocks at some point but neglected to notify you.
,
Nov 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7bdc27ac004ff3b5b86993c1535a95c472098b43 commit 7bdc27ac004ff3b5b86993c1535a95c472098b43 Author: Matthew Jones <mdjones@chromium.org> Date: Fri Nov 17 19:11:27 2017 [Home] Update Chrome Home promo string Change "Not now" to "Not yet". BUG= 783829 Change-Id: I9699116ea54d3b6f55b344463328c8b07ff2fcb7 Reviewed-on: https://chromium-review.googlesource.com/777020 Reviewed-by: Theresa <twellington@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#517501} [modify] https://crrev.com/7bdc27ac004ff3b5b86993c1535a95c472098b43/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomePromoDialog.java [modify] https://crrev.com/7bdc27ac004ff3b5b86993c1535a95c472098b43/chrome/android/java/strings/android_chrome_strings.grd
,
Nov 17 2017
,
Nov 30 2017
+cmasso This is the first of the two patches we would like to merge into 63 (the former). The latter (#5) won't matter since we are not going to use that version of the promo.
,
Nov 30 2017
This bug requires manual review: We are only 4 days from stable. Please contact the milestone owner if you have questions. Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 30 2017
,
Nov 30 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7fb22e5ddaf45446630a0a63c68eac29d48277d commit d7fb22e5ddaf45446630a0a63c68eac29d48277d Author: Matthew Jones <mdjones@chromium.org> Date: Thu Nov 30 23:39:22 2017 [Home] Update Chrome Home promo to use buttons instead of toggle The promo dialog now uses buttons that have different text based on the current state of Chrome Home: Chrome Home enabled: "Turn off" / "Ok" Chrome Home disabled: "Not now" / "Try it" BUG= 783829 TBR=mdjones@chromium.org (cherry picked from commit 2bc11e3400cee981a930411d1051e262a0dfec97) Change-Id: Ic5ca9e5a0c6189654d2338cdee9e6ecdc7f0bed3 Reviewed-on: https://chromium-review.googlesource.com/763609 Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#515666} Reviewed-on: https://chromium-review.googlesource.com/802318 Reviewed-by: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#620} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [delete] https://crrev.com/67687391dfa99542f6a94a5556258ef8eb8b2a68/chrome/android/java/res/layout/chrome_home_promo_toggle.xml [modify] https://crrev.com/d7fb22e5ddaf45446630a0a63c68eac29d48277d/chrome/android/java/src/org/chromium/chrome/browser/widget/bottomsheet/ChromeHomePromoDialog.java [modify] https://crrev.com/d7fb22e5ddaf45446630a0a63c68eac29d48277d/chrome/android/java/strings/android_chrome_strings.grd
,
Dec 5 2017
Works as per expected behavior, The promo dialog should uses buttons. Behavior Verified on 65.0.3285.0 |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 10 2017