New issue
Advanced search Search tips

Issue 783828 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Security



Sign in to add a comment

Heap-buffer-overflow in SkReadBuffer::readRect

Project Member Reported by ClusterFuzz, Nov 10 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6641242044891136

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 16
Crash Address: 0x6040000016bf
Crash State:
  SkReadBuffer::readRect
  SkTextBlob::MakeFromBuffer
  SkTextBlob::Deserialize
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=514197:514231

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6641242044891136

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 10 2017

Labels: Test-Predator-Auto-Owner
Owner: vmp...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/c39d862bce3dd59bb88708fdccc237655146a3d7 (oop: Implement linux oop fonts support.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 2 by est...@chromium.org, Nov 10 2017

Cc: hcm@chromium.org
Components: Internals>Skia
Project Member

Comment 3 by ClusterFuzz, Nov 11 2017

Labels: OS-Mac
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 11 2017

Labels: M-64
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 11 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 11 2017

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0cfacc551f44e0f9d85ea50c86005ed847b2cc55

commit 0cfacc551f44e0f9d85ea50c86005ed847b2cc55
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Sun Nov 12 07:16:58 2017

cc/paint: Validate SkData for text blob deserialization.

This patch verifies that the SkData we use to deserialize a text blob
looks correct (and will not cause an assert in Skia).

R=enne@chromium.org

Bug:  783808 ,  783815 ,  783828 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ib07666354827a70dd4a95a589c60ab12b5e61ae7
Reviewed-on: https://chromium-review.googlesource.com/764582
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515862}
[modify] https://crrev.com/0cfacc551f44e0f9d85ea50c86005ed847b2cc55/cc/paint/paint_op_reader.cc

Project Member

Comment 8 by ClusterFuzz, Nov 13 2017

ClusterFuzz has detected this issue as fixed in range 515861:515862.

Detailed report: https://clusterfuzz.com/testcase?key=6641242044891136

Fuzzer: libFuzzer_paint_op_buffer_fuzzer
Job Type: libfuzzer_chrome_asan
Platform Id: linux

Crash Type: Heap-buffer-overflow READ 16
Crash Address: 0x6040000016bf
Crash State:
  SkReadBuffer::readRect
  SkTextBlob::MakeFromBuffer
  SkTextBlob::Deserialize
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=514197:514231
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan&range=515861:515862

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6641242044891136

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 13 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6641242044891136 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 14 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify

Comment 11 by mmoroz@google.com, Nov 27 2017

Cc: enne@chromium.org
Project Member

Comment 12 by sheriffbot@chromium.org, Feb 19 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 13 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable

Sign in to add a comment