New issue
Advanced search Search tips

Issue 783818 link

Starred by 1 user
Status: Fixed
Owner:
maxmorin@chromium.org
Closed: Apr 2018
Cc:
holmer@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

webrtc_internals_message_handler_unittest.cc not compiled

Project Member Reported by eladalon@chromium.org, Nov 10 2017 
The file exists in the Chrome code-base, but it's never compiled nor used.

Comment 1 by eladalon@chromium.org, Mar 29 2018

Components: Blink>WebRTC
Owner: ----

Comment 2 by guidou@chromium.org, Apr 2 2018

Components: -Blink>WebRTC Blink>WebRTC>Tools

Comment 3 by olka@chromium.org, Apr 5 2018

Owner: maxmorin@chromium.org
Status: Assigned (was: Untriaged)

Comment 4 by maxmorin@chromium.org, Apr 5 2018 

Looks like it was accidentally removed in https://codereview.chromium.org/2176753003. I'll reenable it if it runs without issues.
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e196caf8b264ee4ca0e64aa7ba3dc74a23523be

commit 2e196caf8b264ee4ca0e64aa7ba3dc74a23523be
Author: Max Morin <maxmorin@chromium.org>
Date: Thu Apr 05 10:55:43 2018

Reenable WebRtcInternalsMessageHandlerTest.

It was accidentally disabled in
https://codereview.chromium.org/2176753003.

Bug:  783818 
Change-Id: I52f53bd0130737486e97989643421f9dc93df749
Reviewed-on: https://chromium-review.googlesource.com/997352
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Commit-Queue: Max Morin <maxmorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548382}
[modify] https://crrev.com/2e196caf8b264ee4ca0e64aa7ba3dc74a23523be/content/browser/webrtc/webrtc_internals_message_handler_unittest.cc
[modify] https://crrev.com/2e196caf8b264ee4ca0e64aa7ba3dc74a23523be/content/test/BUILD.gn

Comment 6 by maxmorin@chromium.org, Apr 5 2018

Status: Fixed (was: Assigned)
Thanks for reporting.
►

Sign in to add a comment